accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 17947: ACCUMULO-841 - refactor of randomwalk State
Date Thu, 20 Feb 2014 14:24:30 GMT


> On Feb. 18, 2014, 8:05 p.m., kturner wrote:
> > test/src/main/java/org/apache/accumulo/test/randomwalk/Node.java, line 41
> > <https://reviews.apache.org/r/17947/diff/2/?file=485278#file485278line41>
> >
> >     The naming of State is not consistent w/ RWEnvironment (its not RWState).  I
think dropping RW from RWEnvironemnt would be ok.  The class will be encountered when implementing
this visit() method in which case the context is clear.

I think you're right. In the back of my head I thought there was already a commonly-used Java
"Environment" class, but it's part of CORBA. I'll rename and update the diff.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17947/#review34820
-----------------------------------------------------------


On Feb. 14, 2014, 10:32 a.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17947/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 10:32 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-841
>     https://issues.apache.org/jira/browse/ACCUMULO-841
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> This is a refactoring of the State class used for randomwalk. I tried to balance the
extent of the refactoring with the extent of changes to the tests themselves. So, State is
still a central class, but it delegates to other more focused classes for almost everything
beyond storing just state key/value pairs. Other notes:
> 
> - The node visiting mechanism was unused so it's removed. Module has a maxHops counting
mechanism which does the same thing.
> - The getCredentials() method was only ever used to then get an authentication token,
so the tests now get the token directly, and getCredentials() is gone.
> 
> 
> Diffs
> -----
> 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/Fixture.java 73b51d25b3a1985d80fc6d2c61d4c7c0afd2442c

>   test/src/main/java/org/apache/accumulo/test/randomwalk/Framework.java 9d0192938edd17d03431e4b2c144735bc059be1c

>   test/src/main/java/org/apache/accumulo/test/randomwalk/Module.java 25684809daf29644550c05256c7abaf60fc2e75c

>   test/src/main/java/org/apache/accumulo/test/randomwalk/Node.java 1868adedcbb41040d2b0e2e2edff642799f10673

>   test/src/main/java/org/apache/accumulo/test/randomwalk/RWEnvironment.java PRE-CREATION

>   test/src/main/java/org/apache/accumulo/test/randomwalk/State.java f4102ab5dbff63e18ba5673126eeb5e646b84771

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/BulkMinusOne.java 4ebf23f84aff2162e27c3c9de21bb4ec19e43949

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/BulkPlusOne.java cdfbb3665cf87e94ff37363fdecd60481fabe1db

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/BulkTest.java 4afefd98cad5819c2813180f54471917589d5953

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Compact.java 86dae5c9c4dbfb6809db0260b2911d2ad6705db7

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/ConsistencyCheck.java e60f8cfe4bc9e3ad17b08a20f777c739031e8520

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Merge.java 2dd034595de60e4a7c910acaf70be96d7516c2a5

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Setup.java dad2bccb130f885f4c47646e0c4868a3c86a9fb4

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Split.java 157e2ab6ecdeb65193d074dc63fe76f4ae6ba0c0

>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/Verify.java b2299aa9ed174c8688ea13d47ddffd056d762c24

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/AddSplits.java e03b7f69c8b310184c330b3af134237d5ada466b

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Apocalypse.java 252d52aebd055bdef748f35e3ce04702b968b5e8

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/BatchScan.java 3fa7d473b43460f5d1e51db4eff937cef8f980a2

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/BatchWrite.java f0022748499fb8e92fbf04a5693a19a64b5f9088

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/BulkImport.java d4d6838b1f26152378b3af554a00a3b17886ac98

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ChangeAuthorizations.java
b882a3a3ef1af9e2afa03aa6dd1a512b6fe3cd08 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ChangePermissions.java
73e617595ad2d7afd0f050eb8ddc896b6066d0fe 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CheckBalance.java
4cb0260cc129ea51c246ee69efdfbae46831d808 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CheckPermission.java
50948b308b6a2fc38d607a76e4faad3aec6b9dac 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CloneTable.java 780238584a50aad8c49cc6f4f4b21321b07b52b4

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Compact.java d83055ac049ffcd2d32db93903f2ad25fc92dc87

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ConcurrentFixture.java
df7ddd76ad63d910f57ed5532142e2e8e57d343d 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Config.java 402f13902f976b93ea36fadc2dd8af0c88f3a1de

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CreateNamespace.java
43e6c0636d2d9f780b5c6490bf600f705d7b7466 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CreateTable.java
21ae031776511c42845242a719bc52dc6d9ad072 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/CreateUser.java 24f25f3f36d89aacacc50423c8174003c984ce30

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DeleteNamespace.java
333af3dfc27f2e1432a769c928c06b6996727bb0 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DeleteRange.java
9b44782aae000d15c652e81df1d5c15a3ff5e006 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DeleteTable.java
8adae6424b215879862a81e723a26e1b19475b2d 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/DropUser.java 672c4b8226895aff902ea71f3132d58d635c611d

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/IsolatedScan.java
905aa8e2fd604c176fbe85028040728d78fc5f4f 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ListSplits.java 0f3d87fae3e74145e1c641e6c8ab3328237bfe1a

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Merge.java a16f6a60d350c96e9a846f3586e08784a47dd5b5

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/OfflineTable.java
c4d9babfe58f9df47e99d20f02b028a031774f3c 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/RenameNamespace.java
5aa21ed587721b2f5023d5c370dad9f891605643 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/RenameTable.java
d9a12fbe5f3c452d0fa9c6c0790a8fa0bed10697 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/ScanTable.java 1b22f4af4047a81b5fb00f6ea65309ae86cd414b

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Setup.java 502e9e3b6e202bed0c69c0a7b56e8ab05e901341

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/Shutdown.java 657a60420aa594389e9fd44696bc9c3ef456bcb9

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/StartAll.java 2427d1ef7228be633c1198819c1acd299554275a

>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/StopTabletServer.java
c8da3d8cf5529bc404a2bb2cb8c7989f6faa22d4 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Compact.java 66acc86ecc49a9ed15fd6f891f24a631ae50bf23

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Flush.java c4923dec351ad8d3c3022cb7ef149db83de2b50c

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Init.java bfad7303cbfd2ab3e013c842c2081c43cccf1259

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Merge.java bb3cf6082bfcb1bf97b3ef0d3ead37c49998d6f8

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Setup.java 0aa36c455f59234eab4252670e23be0f765ccddf

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Split.java 3b477620e1295ff4ab9fa831b0eb2b579934a459

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/TearDown.java 1624371073c1995abc90ff59fee4ead66fc58bf9

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Transfer.java 93f0d551b2ed66bb9c846113b96ec35061091e7d

>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Verify.java 86a5768ddf3660aac6e8da822d1dc9323d72fd14

>   test/src/main/java/org/apache/accumulo/test/randomwalk/image/Commit.java 3a805ef54b2cd63c1715109df48a315745a1c763

>   test/src/main/java/org/apache/accumulo/test/randomwalk/image/ImageFixture.java 723bfa87346f9da3a4f2cf8d4838f610a3c11632

>   test/src/main/java/org/apache/accumulo/test/randomwalk/image/ScanMeta.java 77c66ed19de0ebfc75729126a42ccbf41299600f

>   test/src/main/java/org/apache/accumulo/test/randomwalk/image/TableOp.java 5f6518027b1380a7eccfe2047daf4d24b160dbdb

>   test/src/main/java/org/apache/accumulo/test/randomwalk/image/Verify.java ba0ed735cff38cec3fc440df2d541c8365f3218d

>   test/src/main/java/org/apache/accumulo/test/randomwalk/image/Write.java 53dfe21d7d1019d775dea037cd472d2c180a181d

>   test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/Commit.java 115363444316219a6fccf22184be136272bf73be

>   test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/CopyTable.java 5a2172d6eddf302fb266c82e174ab235358e9cd6

>   test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/CreateTable.java
5f379138bea8a6cc609abd8d756b0141ea4637f0 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/DropTable.java b6cdb4380d54770e433cd0f3ffce782c3dfe8fc3

>   test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/MultiTableFixture.java
8b209b37eea2e326c94cd4c0e0761d9e7a99d86e 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/OfflineTable.java
3e16f4d8fc327ff4769622a46a9943b85416501e 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/Write.java 0b9c0620cf9815a6eb28662743bc4acc89517cf0

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/AlterSystemPerm.java
cfc2067a52e8c30a8feabacd0c5988ad1ba92292 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/AlterTable.java a879361cd722e45467265e8a5afbbc9315774aff

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/AlterTablePerm.java
335ae31dc05ebade9f30187a2ab4d9c79ae205c6 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/Authenticate.java 14f502887b94c47243478dd9ef0d7901fa88c465

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/ChangePass.java 439e7243853151b5d79232f6f034ccba95cd599d

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/CreateTable.java 4c10b1313a0b773cc5f320f848ded5f7037b71da

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/CreateUser.java cffcb9525dbcc32204d95a095008fe9b3772ace5

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/DropTable.java cfcc27072bc2d80531e7c9a351493d6cea1025fc

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/DropUser.java ddf39aaf667506c4cb12faf1b1a0d98077e490a7

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/SecurityFixture.java
30f12fbc57b625489271a3a4a23f8c21b4df9ec1 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/SecurityHelper.java
81192bd398c489075228e055a4b5290ec89b1e97 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/SetAuths.java 54bc34aface7428c3149ffbc438cc0be82cee72f

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/TableOp.java b084dcc0da2054b27f11229b3b2c58a3c97bd34e

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/Validate.java 03718ce4e044e985cb309c01c531630cf9222a33

>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/WalkingSecurity.java
76528c658381089cbef35cd2321676ad92659b43 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/BatchVerify.java
04da64dae36908b741ad2e47395813882ea07e70 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/Commit.java cd1ccaba7af931d8dd8a8fcc25a5d8812c3149f5

>   test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/MapRedVerify.java
f60fe44c66a6f23242aa442f279ecb86c5162109 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/SequentialFixture.java
927a803e407d8ade600388ff93218a1ddfd56f1a 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/Write.java d14f96e620262c4a47fcc532a6e377431b9a5ee2

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/BulkInsert.java 41acce2575de571fd48fdf5759455be3c5698e33

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/CloneIndex.java 5a22e1dc295a54ca86270e0c84c00fd113679ab0

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Commit.java b7ba8258eedd03290365e1f4ac2ce0a7811ebadd

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/CompactFilter.java 4ed251313690396b4f4be72b58c20f644ca05f56

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Delete.java b46be38c4a382004aefff9a61409424e5f67ba68

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/DeleteSomeDocs.java 9aa9e81d21f641d639fc273e051003ad5e1527ec

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/DeleteWord.java fa8917a7560289d9ff7e8a122388ce2ab9e23dc5

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/ExportIndex.java 812112efbec75bc2cf48fc8534bdcf1ee8e5b119

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Flush.java 4496b71630229c80ec5c8fc1e159ac980a3d2345

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Grep.java 6b674edc68aeb2bdc79e20d466c04367a3d2074d

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Insert.java 8e81acb78453d2188d182a6afb15161177a800fd

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Merge.java 8e6eee3c274a53b65ac2ff7ccc4f33ece477ec74

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Reindex.java 066ce275c65f1df7f87d81bf4dc696667306cc67

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Search.java ecd40619e73582dec7e868629171e74eac8e8e6c

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/ShardFixture.java ccf4f3534c9e948284f9a91f92d4582f5403c283

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Split.java 0d41316985fa1ad020da304ce8edf7ef86337686

>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/VerifyIndex.java 8696321c0dada4b7cbea07c541479c7d300b1e91

>   test/src/main/java/org/apache/accumulo/test/randomwalk/unit/CreateTable.java 12584f707da055105608523af2f5c82a96511fd6

>   test/src/main/java/org/apache/accumulo/test/randomwalk/unit/DeleteTable.java 20ad3db0453797a72dac4adbd90b5f8e0d37a6b2

>   test/src/main/java/org/apache/accumulo/test/randomwalk/unit/Ingest.java 045a3ee7d95a252a3513bd68d747c7761d71cb72

>   test/src/main/java/org/apache/accumulo/test/randomwalk/unit/Scan.java 06cb62bb7e1482001c8a480397f797e5f35b6e13

>   test/src/main/java/org/apache/accumulo/test/randomwalk/unit/Verify.java 6c1b7a21a7f24880d714205e9dcf127f072d416a

> 
> Diff: https://reviews.apache.org/r/17947/diff/
> 
> 
> Testing
> -------
> 
> Compile works; ran MultiTable randomwalk, which does run MR jobs to test getMapReduceJars();
also ran Security randomwalk.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message