accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 17426: ACCUMULO-1948 Tablet constructor no longer leaking this
Date Tue, 04 Feb 2014 18:44:27 GMT


> On Feb. 4, 2014, 11:46 a.m., kturner wrote:
> > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java,
line 368
> > <https://reviews.apache.org/r/17426/diff/5/?file=468725#file468725line368>
> >
> >     Actually this is probably expected behavior.  A report could be in the  queue
while a tablets is closing.  So a tablet is closed and cleans  up the map, then the queued
is processed adding the tablet back to the map.
> 
> Bill Havanki wrote:
>     Ah, tricky. OK, I'll update the log message to something like just "Cleaned up report
for closed tablet" - good?
> 
> kturner wrote:
>     That sounds good.

OK, new diff is in. Anything else before committing? Thanks again for reviewing, I appreciate
it.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17426/#review33600
-----------------------------------------------------------


On Feb. 4, 2014, 1:43 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17426/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 1:43 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1948
>     https://issues.apache.org/jira/browse/ACCUMULO-1948
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Change in the construction of the cross-referencing between Tablet and TabletResourceManager
to avoid the Tablet constructor leaking this.
> 
> 
> Diffs
> -----
> 
>   server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 7ce270b361f1df212fa3bd3f46e46c3b2b080df3

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 080cc203e9230c62ca913fa9bf80d671bdd2e303

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
e95843775c85ecf90a2b4c7afce91094381da450 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17426/diff/
> 
> 
> Testing
> -------
> 
> Added unit test. Tested on pseudo-cluster with shell activity, randomwalk MultiTable
test.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message