accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 17426: ACCUMULO-1948 Tablet constructor no longer leaking this
Date Tue, 04 Feb 2014 16:27:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17426/
-----------------------------------------------------------

(Updated Feb. 4, 2014, 11:27 a.m.)


Review request for accumulo.


Changes
-------

Addressing Keith's issues. Thanks for the thoughtful review, Keith!


Bugs: ACCUMULO-1948
    https://issues.apache.org/jira/browse/ACCUMULO-1948


Repository: accumulo


Description
-------

Change in the construction of the cross-referencing between Tablet and TabletResourceManager
to avoid the Tablet constructor leaking this.


Diffs (updated)
-----

  server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436 
  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 5ea2401acc720c70d58ee04c2dd82dc79fcf2b99

  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 9d08c81f9b07a8c5f8a281769fd2914f5c8fc82b

  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
e95843775c85ecf90a2b4c7afce91094381da450 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/17426/diff/


Testing
-------

Added unit test. Tested on pseudo-cluster with shell activity, randomwalk MultiTable test.


Thanks,

Bill Havanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message