Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============2497841004769950704=="
MIME-Version: 1.0
Subject: Re: Review Request 17426: ACCUMULO-1948 Tablet constructor no longer
 leaking
 this
From: "Bill Havanki" <bhavanki@clouderagovt.com>
To: "Eric Newton" <eric.newton@gmail.com>,
 "Bill Havanki" <bhavanki@clouderagovt.com>,
 "accumulo" <dev@accumulo.apache.org>, keith@deenlo.com
Date: Tue, 28 Jan 2014 20:10:58 -0000
Message-ID: <20140128201058.20513.32946@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Havanki" <noreply@reviews.apache.org>
References: <20140128124744.13731.33840@reviews.apache.org>
In-Reply-To: <20140128124744.13731.33840@reviews.apache.org>
Reply-To: "Bill Havanki" <bhavanki@clouderagovt.com>

--===============2497841004769950704==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17426/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 3:10 p.m.)


Review request for accumulo.


Changes
-------

Testing of diff #2 revealed that the Tablet constructor checks for needing major compaction, and that check requires tablet configuration information to be available in the TabletResourceManager. Rather than reverting to diff #1, this diff instead replaces the cross-reference between Tablet and TabletResourceManager.

- TabletResourceManager now stores a key extent and table configuration, not a tablet. Both items are final fields.
- The addTableResource call formerly done in setTablet must now be done by calling code.
- TabletState kept by the resource managers no longer includes a tablet reference, only its key extent.
- Therefore, the tablet needs to be looked up when minor compaction is initiated by MemoryManagementFramework. So, TabletServer now allows lookup of online tablets. The minor compaction attempt is skipped if the tablet is offline.


Bugs: ACCUMULO-1948
    https://issues.apache.org/jira/browse/ACCUMULO-1948


Repository: accumulo


Description
-------

Change in the construction of the cross-referencing between Tablet and TabletResourceManager to avoid the Tablet constructor leaking this.


Diffs (updated)
-----

  server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436 
  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 40dfcf0fa1715fbb0ff69e78bdf8954146a36b20 
  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 5c1f6ce5f95523ef16005902c99a8f974e9e2baf 
  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java e95843775c85ecf90a2b4c7afce91094381da450 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/17426/diff/


Testing
-------

Added unit test. Real cluster testing TBD.


Thanks,

Bill Havanki


--===============2497841004769950704==--