Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6687610AE4 for ; Tue, 28 Jan 2014 17:12:07 +0000 (UTC) Received: (qmail 71657 invoked by uid 500); 28 Jan 2014 17:12:06 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 71619 invoked by uid 500); 28 Jan 2014 17:12:05 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 71609 invoked by uid 99); 28 Jan 2014 17:12:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2014 17:12:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 32DEB1D4680; Tue, 28 Jan 2014 17:12:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0535543232095913901==" MIME-Version: 1.0 Subject: Re: Review Request 17426: ACCUMULO-1948 Tablet constructor no longer leaking this From: "Bill Havanki" To: "Bill Havanki" , "accumulo" , keith@deenlo.com Date: Tue, 28 Jan 2014 17:12:04 -0000 Message-ID: <20140128171204.6810.39270@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/17426/ X-Sender: "Bill Havanki" References: <20140128162618.6810.77744@reviews.apache.org> In-Reply-To: <20140128162618.6810.77744@reviews.apache.org> Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============0535543232095913901== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Jan. 28, 2014, 11:26 a.m., kturner wrote: > > Ship It! Testing on a cluster I discovered a problem - the Tablet constructor calls needsMajorCompaction at its end, and without the tablet / tablet config set in the TabletResourceManager by then, I get an NPE. So I'll have to try something different, but I think I have a good idea for it. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17426/#review32996 ----------------------------------------------------------- On Jan. 28, 2014, 7:47 a.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17426/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 7:47 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1948 > https://issues.apache.org/jira/browse/ACCUMULO-1948 > > > Repository: accumulo > > > Description > ------- > > Change in the construction of the cross-referencing between Tablet and TabletResourceManager to avoid the Tablet constructor leaking this. > > > Diffs > ----- > > server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436 > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 40dfcf0fa1715fbb0ff69e78bdf8954146a36b20 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 5c1f6ce5f95523ef16005902c99a8f974e9e2baf > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java e95843775c85ecf90a2b4c7afce91094381da450 > server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/17426/diff/ > > > Testing > ------- > > Added unit test. Real cluster testing TBD. > > > Thanks, > > Bill Havanki > > --===============0535543232095913901==--