Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 492531084E for ; Mon, 27 Jan 2014 22:15:16 +0000 (UTC) Received: (qmail 61534 invoked by uid 500); 27 Jan 2014 22:15:15 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 61443 invoked by uid 500); 27 Jan 2014 22:15:15 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 61428 invoked by uid 99); 27 Jan 2014 22:15:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jan 2014 22:15:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F6D61D4543; Mon, 27 Jan 2014 22:15:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3910884201131841596==" MIME-Version: 1.0 Subject: Review Request 17426: ACCUMULO-1948 Tablet constructor no longer leaking this From: "Bill Havanki" To: "Bill Havanki" , "accumulo" Date: Mon, 27 Jan 2014 22:15:12 -0000 Message-ID: <20140127221512.13731.33322@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/17426/ X-Sender: "Bill Havanki" Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============3910884201131841596== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17426/ ----------------------------------------------------------- Review request for accumulo. Bugs: ACCUMULO-1948 https://issues.apache.org/jira/browse/ACCUMULO-1948 Repository: accumulo Description ------- Change in the construction of the cross-referencing between Tablet and TabletResourceManager to avoid the Tablet constructor leaking this. Diffs ----- server/tserver/pom.xml b627de092faa2b5b4dbc5f8b9e4fb7af696ca436 server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 40dfcf0fa1715fbb0ff69e78bdf8954146a36b20 server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 5c1f6ce5f95523ef16005902c99a8f974e9e2baf server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java e95843775c85ecf90a2b4c7afce91094381da450 server/tserver/src/test/java/org/apache/accumulo/tserver/TabletResourceManagerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17426/diff/ Testing ------- Added unit test. Real cluster testing TBD. Thanks, Bill Havanki --===============3910884201131841596==--