Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C495C10E59 for ; Wed, 22 Jan 2014 21:21:35 +0000 (UTC) Received: (qmail 18810 invoked by uid 500); 22 Jan 2014 21:21:35 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 18767 invoked by uid 500); 22 Jan 2014 21:21:34 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 18756 invoked by uid 99); 22 Jan 2014 21:21:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Jan 2014 21:21:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A4ACF1D454D; Wed, 22 Jan 2014 21:21:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3435716787367786094==" MIME-Version: 1.0 Subject: Re: Review Request 17192: ACCUMULO-2225 handle IllegalArgumentExceptions from Hadoop on host lookup failure. From: "Mike Drob" To: "Bill Havanki" Cc: "Sean Busbey" , "accumulo" , "Mike Drob" Date: Wed, 22 Jan 2014 21:21:33 -0000 Message-ID: <20140122212133.22352.41021@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mike Drob" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/17192/ X-Sender: "Mike Drob" References: <20140122191304.11320.68928@reviews.apache.org> In-Reply-To: <20140122191304.11320.68928@reviews.apache.org> Reply-To: "Mike Drob" X-ReviewRequest-Repository: accumulo --===============3435716787367786094== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17192/#review32548 ----------------------------------------------------------- src/server/src/main/java/org/apache/accumulo/server/Accumulo.java Also, "Uknown" src/server/src/main/java/org/apache/accumulo/server/Accumulo.java There doesn't really need to be duplication, since IIRC IllegalArgument is already a RuntimeExceptione. - Mike Drob On Jan. 22, 2014, 7:13 p.m., Sean Busbey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17192/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 7:13 p.m.) > > > Review request for accumulo and Bill Havanki. > > > Bugs: ACCUMULO-2225 > https://issues.apache.org/jira/browse/ACCUMULO-2225 > > > Repository: accumulo > > > Description > ------- > > ACCUMULO-2225 handle IllegalArgumentExceptions from Hadoop on host lookup failure. > > Looks for cases where we treat IOExceptions out of Hadoop specially, then attempts to replicate for UnknownHostExceptions that have been wrapped in IllegalArgumentExceptions. > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java e02c19785c373170b2b0d47266a6988adeec7e17 > src/server/src/main/java/org/apache/accumulo/server/Accumulo.java 253962bca5f2573fdfa87b82e145938e190842ed > src/server/src/main/java/org/apache/accumulo/server/master/tableOps/DeleteTable.java 1c4d4ad8af30350d93f6dcfe2291463a90c835d3 > src/server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java 29b8455a2dce5ecf2195d9704980e3e9749683f4 > src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java c8d1ea0872564643342387373d85b5ac87a57540 > src/server/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 4a39050a17f84293c52f09b62932be5b957c8a91 > > Diff: https://reviews.apache.org/r/17192/diff/ > > > Testing > ------- > > builds on both hadoop profiles. starting functional tests now in combination with 17132 > > > Thanks, > > Sean Busbey > > --===============3435716787367786094==--