Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============3491935103068923581=="
MIME-Version: 1.0
Subject: Re: Review Request 16857: ACCUMULO-2182 - first set of backports to
 1.4.5-SNAPSHOT
From: "Mike Drob" <mdrob@mdrob.com>
To: "Josh Elser" <josh.elser@gmail.com>
Cc: "Mike Drob" <mdrob@mdrob.com>, "accumulo" <dev@accumulo.apache.org>,
 "Bill Havanki" <bhavanki@clouderagovt.com>
Date: Tue, 14 Jan 2014 17:51:56 -0000
Message-ID: <20140114175156.7608.81638@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Mike Drob" <noreply@reviews.apache.org>
References: <20140114140949.7608.72781@reviews.apache.org>
In-Reply-To: <20140114140949.7608.72781@reviews.apache.org>
Reply-To: "Mike Drob" <mdrob@mdrob.com>

--===============3491935103068923581==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16857/#review31737
-----------------------------------------------------------

Ship it!


src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java
<https://reviews.apache.org/r/16857/#comment60465>

    It looks like there is a potential concurrency issue between this method and isMultiTableBatchWriterInitialized, but I haven't traced deep enough to discover if that's a real problem for us or not. Also, the issue exists upstream, so this is a faithful backport, if nothing else. Maybe it makes sense to open a new JIRA for the bug.


- Mike Drob


On Jan. 14, 2014, 2:09 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16857/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 2:09 p.m.)
> 
> 
> Review request for accumulo and Josh Elser.
> 
> 
> Bugs: ACCUMULO-2182
>     https://issues.apache.org/jira/browse/ACCUMULO-2182
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Backports of the following to 1.4.5-SNAPSHOT: ACCUMULO-1123, ACCUMULO-2104 / ACCUMULO-2106. This review request is a combined diff; I have a patch file with separate commits for -1123 and -2104/-2106.
> 
> These backports were done "by hand" rather than cherry-picking, so double-checking against the original tickets is most welcome.
> 
> 
> Diffs
> -----
> 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java 1c73414 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/image/ImageFixture.java fe406e7 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/multitable/MultiTableFixture.java d7f65ae 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/ChangePass.java 429c8cd 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/CreateUser.java afefee8 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/SecurityHelper.java 52a4672 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/security/TableOp.java e0b8deb 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/sequential/SequentialFixture.java 5714893 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/shard/ShardFixture.java b91c81c 
> 
> Diff: https://reviews.apache.org/r/16857/diff/
> 
> 
> Testing
> -------
> 
> Successfully ran following randomwalk tests under 1.4.x: Image, Sequential, Shard, Multitable. Security test running 17 hours so far without failure due to BAD_CREDENTIALS, which is what -1123 fixes.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


--===============3491935103068923581==--