accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines" <vi...@apache.org>
Subject Review Request 17468: ACCUMULO-1479 - simplification of namespace SecurityOperation changes
Date Tue, 28 Jan 2014 21:43:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17468/
-----------------------------------------------------------

Review request for accumulo.


Repository: accumulo


Description
-------

This is a refactor of the SecurityOperation changes done by the namespace implementation.
Root reason being to simplify the changes to the can____ operations to prevent them from being
overly complex. Surrounding changes were made to add Namespace permissions for bulk import
and dropping the namespace. Additionally, some other changes were made around the Create fate
operation to minimize the number of namespaceId lookups, as well as to do namespace checking
before security checking, which could have resulted in strange errors to clients.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/security/NamespacePermission.java 1066bc4 
  server/base/src/main/java/org/apache/accumulo/server/security/AuditedSecurityOperation.java
bbfa71b 
  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java 4b302f0

  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java afcda86 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 9535781

  test/src/main/java/org/apache/accumulo/test/randomwalk/security/CreateTable.java 16310a5

  test/src/test/java/org/apache/accumulo/test/NamespacesIT.java addb377 

Diff: https://reviews.apache.org/r/17468/diff/


Testing
-------

All tests, including ITs, run successfully.


Thanks,

John Vines


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message