accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 16966: ACCUMULO-2198 - improve time tracking for unbalanced servers in Concurrent randomwalk
Date Thu, 16 Jan 2014 14:47:40 GMT


> On Jan. 16, 2014, 9:37 a.m., Eric Newton wrote:
> > Ship It!

Upon merging to 1.5.1-SNAPSHOT I notice that a similar fix to the time tracking is in place,
with an additional allowance for requiring 3 checks before failing. I think this would be
good for 1.4.5-SNAPSHOT as well so I will backport that before merging this change as well.

Thanks Eric!


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16966/#review32027
-----------------------------------------------------------


On Jan. 16, 2014, 9:11 a.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16966/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 9:11 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2198
>     https://issues.apache.org/jira/browse/ACCUMULO-2198
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> * Moves tracking of last unbalanced time in Concurrent randomwalk from node property
to test state
> * Adds removal of tracked time after run, to avoid use in later tests
> * Fixes tracking so that time is not reset when servers unbalanced and 15-minute allowance
not expired
> 
> 
> Diffs
> -----
> 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/State.java f9bd84e

>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/concurrent/CheckBalance.java
beb8327 
>   src/server/src/main/java/org/apache/accumulo/server/test/randomwalk/concurrent/ConcurrentFixture.java
62fac56 
> 
> Diff: https://reviews.apache.org/r/16966/diff/
> 
> 
> Testing
> -------
> 
> Ran Concurrent test to completion several times.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message