accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hung Pham" <hp...@clouderagovt.com>
Subject Re: Review Request 16908: Add a 3rd argument to functional test RunTests.java to allow a timeout factor for mapred.task.timeout and run.py -f flag
Date Thu, 16 Jan 2014 13:17:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16908/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 1:17 p.m.)


Review request for accumulo.


Changes
-------

Following changes are in this version 3 patch:
1)  Change in 
src/server/src/main/java/org/apache/accumulo/server/monitor/servlets/DefaultServlet.java was
left out for another JIRA
2)  New configuration property 'RunTests.timeout_factor' was added as a constant (final) variable
for RunTests outer class
3)  In Configuration, set 'RunTests.timeout_factor' with value of 'main''s 3rd argument, 'timeout_factor',
which is optional (in that case, defaults to 1)
4)  Instance variable 'mapper_timeout_factor' was added to TestMapper inner class
5)  An overridden setup method was added to TestMapper to get the value of 'RunTests.timeout_factor'
from Configuration and give it to 'mapper_timeout_factor'
6)  varargs in 'run' and 'main' methods were changed to String[]
7)  Spurious string concatenation was eliminated (ie, from "timeout_factor" + " must be an
integer: " to simply "timeout_factor must be an integer: ")
8)  Explanation of timeout_factor at bottom of README was reworded.


Bugs: ACCUMULO-2005
    https://issues.apache.org/jira/browse/ACCUMULO-2005


Repository: accumulo


Description
-------

ACCUMULO-2005: Add a 3rd argument to functional test RunTests.java to allow a timeout factor
for mapred.task.timeout and run.py -f flag.  Also changed 'ex' to 'e' on line 274 of src/server/src/main/java/org/apache/accumulo/server/monitor/servlets/DefaultServlet.java


Diffs (updated)
-----

  src/server/src/main/java/org/apache/accumulo/server/test/functional/RunTests.java 1a19bb5

  test/system/auto/README 4773393 

Diff: https://reviews.apache.org/r/16908/diff/


Testing
-------

Testing was done on small cluster (4 nodes: master + 3 workers) to ensure MR job complete
successfully instead of failing out due to timeouts that lead to killed attempts.   Test results
can be provided upon request.


Thanks,

Hung Pham


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message