accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 16427: ACCUMULO-2076 add Instance builder based on classpath resources
Date Thu, 02 Jan 2014 14:51:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16427/#review31036
-----------------------------------------------------------



src/core/src/main/java/org/apache/accumulo/core/client/ClasspathZooKeeperInstanceFactory.java
<https://reviews.apache.org/r/16427/#comment59383>

    Please see the comment I just made in jira.  I think adding this when ClientConfiguration
was added in 1.6.0 is very confusing from the the users perspective.  Provides slightly different
ways to accomplish the same goal.


- kturner


On Dec. 26, 2013, 6:33 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16427/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 6:33 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2076
>     https://issues.apache.org/jira/browse/ACCUMULO-2076
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Writing client code for retrieving zookeeper and instance information is both tedious
and error prone. It would be great to remove this boiler-plate burden from users.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/client/ClasspathZooKeeperInstanceFactory.java
PRE-CREATION 
>   src/core/src/main/java/org/apache/accumulo/core/client/InstanceFactory.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/16427/diff/
> 
> 
> Testing
> -------
> 
> None, yet. :)
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message