Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
MIME-Version: 1.0
In-Reply-To: 
 <CAL5zq9axWU++o5LS72XRaSO5T3HbkHM8gemdCR2HGkz3AwNJSQ@mail.gmail.com>
References: 
 <CAL5zq9a-Vi9d8Z8YXBR0Hy-JiyiQhFTE9eEagV8qUBNXN-AOcw@mail.gmail.com>
 <CABwccFGRfwtrnByug3Qn52iSTZJXqtBSx51KS1M4qZaD6UUnLg@mail.gmail.com>
 <CAL5zq9axWU++o5LS72XRaSO5T3HbkHM8gemdCR2HGkz3AwNJSQ@mail.gmail.com>
From: Sean Busbey <busbey+ml@clouderagovt.com>
Date: Fri, 13 Dec 2013 15:34:47 -0600
Message-ID: 
 <CABwccFF9wN9je1GS-=m1pxv2OWgx=581iKVsC-+AecsN-Ha_=g@mail.gmail.com>
Subject: Re: Resource leak warnings
To: "dev@accumulo apache. org" <dev@accumulo.apache.org>
Content-Type: multipart/alternative; boundary=089e0168156e7acede04ed713c7f

--089e0168156e7acede04ed713c7f
Content-Type: text/plain; charset=UTF-8

On Fri, Dec 13, 2013 at 3:26 PM, Christopher <ctubbsii@apache.org> wrote:

> On Fri, Dec 13, 2013 at 3:55 PM, Sean Busbey <busbey+ml@clouderagovt.com>
> wrote:
> > I think the answer should be #3 and I am willing to find time to
> implement
> > it next week.
>
> That's great. In the meantime, I'm doing #4, so I can clear the noise
> and focus on my own tickets.
>
>
Could you just do #4 as a patch on your own local repo? It should be
relatively easy to keep rebased given that it's just an interface.


>
> > Also, you should not be able to use a Connection that is attached to a
> > now-closed Instance. I would also consider such use a bug.
> >
> [snip]
>
> It's not just the Connection you'd have to enforce not being re-used
> after the Instance is closed... it's every object our factory-based
> API can give you, all the way down. That's not a small change.
>
>
I agree that fixing things to always expose the bug would be hard. I don't
think that changes that it's a bug.


-- 
Sean

--089e0168156e7acede04ed713c7f--