Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4BEA610EF4 for ; Mon, 16 Dec 2013 16:34:01 +0000 (UTC) Received: (qmail 81952 invoked by uid 500); 16 Dec 2013 16:33:07 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 81436 invoked by uid 500); 16 Dec 2013 16:32:31 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 81276 invoked by uid 99); 16 Dec 2013 16:32:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Dec 2013 16:32:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1EAE41D3135; Mon, 16 Dec 2013 16:32:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5388738129356385347==" MIME-Version: 1.0 Subject: Re: Review Request 15947: ACCUMULO-1944 - functional test coverage From: "Bill Havanki" To: "Bill Havanki" , "accumulo" , "Sean Busbey" Date: Mon, 16 Dec 2013 16:32:22 -0000 Message-ID: <20131216163222.14744.46019@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/15947/ X-Sender: "Bill Havanki" References: <20131202204434.12251.25823@reviews.apache.org> In-Reply-To: <20131202204434.12251.25823@reviews.apache.org> Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============5388738129356385347== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15947/ ----------------------------------------------------------- (Updated Dec. 16, 2013, 11:32 a.m.) Review request for accumulo. Changes ------- Implementing Sean's feedback. Bugs: ACCUMULO-1944 https://issues.apache.org/jira/browse/ACCUMULO-1944 Repository: accumulo Description ------- The -C flag for test/system/auto/run.py did not work. This changeset allows it to work again if a functional Cobertura installation is placed under $ACCUMULO_HOME/lib/test/cobertura. The code for producing instrumented Accumulo code was inactive and out of date. It was reworked so that, if -C is passed, the Accumulo JARs are instrumented and placed into a location ahead of their standard location in the test classpath. (If -C is not passed, any instrumented JARs are removed.) The classpath is also dynamically adjusted to include whatever Cobertura JAR is available; its name includes a version number (as of 2.0.x). The command-line scripts shipped with Cobertura 2.0.x are out of date and do not work out of the box. Pull request #102 was submitted to cobertura/cobertura on Github to fix the problem; in lieu of that, the scripts must be manually updated to use a correct classpath. Diffs (updated) ----- test/system/auto/TestUtils.py f6eca67 test/system/auto/run.py 8e1a9bb Diff: https://reviews.apache.org/r/15947/diff/ Testing ------- Ran simple and stress functional tests on 1.4.5-SNAPSHOT, both with and without -C. Verified that coverage reports are generated. Thanks, Bill Havanki --===============5388738129356385347==--