Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B8A4D1026F for ; Thu, 5 Dec 2013 20:49:49 +0000 (UTC) Received: (qmail 6065 invoked by uid 500); 5 Dec 2013 20:49:49 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 6025 invoked by uid 500); 5 Dec 2013 20:49:49 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 6015 invoked by uid 99); 5 Dec 2013 20:49:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Dec 2013 20:49:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 754491D3D21; Thu, 5 Dec 2013 20:49:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6661997196267024440==" MIME-Version: 1.0 Subject: Re: Review Request 16043: ACCUMULO-1959 - deprecate a Value constructor From: "Josh Elser" To: "Bill Havanki" , "accumulo" , "Josh Elser" Date: Thu, 05 Dec 2013 20:49:44 -0000 Message-ID: <20131205204944.25728.24708@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/16043/ X-Sender: "Josh Elser" References: <20131205204741.12251.10729@reviews.apache.org> In-Reply-To: <20131205204741.12251.10729@reviews.apache.org> Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============6661997196267024440== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16043/#review29834 ----------------------------------------------------------- Ship it! Ship It! - Josh Elser On Dec. 5, 2013, 8:47 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16043/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 8:47 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1959 > https://issues.apache.org/jira/browse/ACCUMULO-1959 > > > Repository: accumulo > > > Description > ------- > > Very minor change, deprecating a constructor for the Value class where a needless double-copy of the input is performed. I also added a unit test for Value, which really could use one. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/data/Value.java 7d3cf8f20aa12205d25027d6ad06e4a3f6062b2e > core/src/test/java/org/apache/accumulo/core/data/ValueTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/16043/diff/ > > > Testing > ------- > > Implemented and ran unit test before and after change, all tests pass. > > > Thanks, > > Bill Havanki > > --===============6661997196267024440==--