accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 16427: ACCUMULO-2076 add Instance builder based on classpath resources
Date Thu, 26 Dec 2013 18:47:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16427/#review30877
-----------------------------------------------------------


Wait, I just noticed that you have this RB marked as 1.4.5-SNAPSHOT (and your javadoc has
@since 1.4.5, etc) but your original ticket is marked for 1.7.0. I do not think this should
pushed back to 1.4.5 or 1.5.1. What is your intent?

Also, I was just talking to Bill Slacum about creating Instances earlier by chance. Have you
considered expanding this to also support HdfsZooInstance and MiniAccumuloInstance? This would
also give us flexibility in (if we move this direction) to having threadsafe and non-threadsafe
variants of the aforementioned Instances (also moving towards a fluent interface like Bill
Havanki mentioned).

- Josh Elser


On Dec. 26, 2013, 6:33 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16427/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 6:33 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2076
>     https://issues.apache.org/jira/browse/ACCUMULO-2076
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Writing client code for retrieving zookeeper and instance information is both tedious
and error prone. It would be great to remove this boiler-plate burden from users.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/client/ClasspathZooKeeperInstanceFactory.java
PRE-CREATION 
>   src/core/src/main/java/org/apache/accumulo/core/client/InstanceFactory.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/16427/diff/
> 
> 
> Testing
> -------
> 
> None, yet. :)
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message