accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <>
Subject Re: Review Request 16224: ACCUMULO-1986 - data integrity checks for Key and Mutation Thrift constructors
Date Mon, 16 Dec 2013 15:47:41 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 16, 2013, 10:47 a.m.)

Review request for accumulo.


Mike Drob's suggestions: remove import static *, rename checkCU to verifyColumnUpdate.

Bugs: ACCUMULO-1986

Repository: accumulo


Integrity checks for constructing Key and Mutation objects from Thrift.

To make adding unit tests easier, I updated KeyTest and MutationTest to use JUnit 4 annotations.
That drove the need to rename an assertEquals method in MutationTest, hence all the changes
to "checkCU" there.

See the JIRA ticket for a list of classes that I evaluated for these same sort of integrity

Diffs (updated)

  src/core/src/main/java/org/apache/accumulo/core/data/ cfb0b5c 
  src/core/src/main/java/org/apache/accumulo/core/data/ 3979da9 
  src/core/src/test/java/org/apache/accumulo/core/data/ 9a7f0d7 
  src/core/src/test/java/org/apache/accumulo/core/data/ 38ddcad 



Unit tests and functional tests pass.


Bill Havanki

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message