accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 16196: ACCUMULO-1896
Date Thu, 12 Dec 2013 21:55:23 GMT


> On Dec. 12, 2013, 2:11 a.m., Sean Busbey wrote:
> > pom.xml, lines 315-442
> > <https://reviews.apache.org/r/16196/diff/1/?file=396796#file396796line315>
> >
> >     Please leave out the move of unrelated pom sections.
> 
> Mike Drob wrote:
>     Ugh. No idea why it shows up like that, since those are not the lines moved in the
diff at all. It looks like review board decided that when going from ABCDE to ACDBE that CD
moved instead of B... Will try uploading a new diff to see if that fixes it.
> 
> Mike Drob wrote:
>     Nope, couldn't do anything about it. Attaching the raw patch to the JIRA so that
somebody can at least look at it that way.

Looked at the raw patch on the ticket. fine to resolve.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16196/#review30239
-----------------------------------------------------------


On Dec. 11, 2013, 11:18 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16196/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 11:18 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Move .deb generation to a profile so that mvn install works out of the box.
> 
> 
> Diffs
> -----
> 
>   README bc469fc 
>   pom.xml 9d33818 
> 
> Diff: https://reviews.apache.org/r/16196/diff/
> 
> 
> Testing
> -------
> 
> Followed new instructions in the README to build .deb files and then inspected the contents
to make sure they are correct.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message