accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 16187: ACCUMULO-1984 - Clean up Instance closing
Date Wed, 11 Dec 2013 19:31:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16187/#review30213
-----------------------------------------------------------



src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooReader.java
<https://reviews.apache.org/r/16187/#comment57826>

    Add comments to caution users about the possibility of interruption.


- Mike Drob


On Dec. 11, 2013, 6:52 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16187/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 6:52 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1984
>     https://issues.apache.org/jira/browse/ACCUMULO-1984
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Eliminates throwing of InterruptedException from various close methods (while adding
implementation of Closeable). Search through the source reveals no further close methods that
throw InterruptedException.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/client/Instance.java 1820e7a5848aac82a81e257909047161e4ecce24

>   src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java fcf8f55dcc7e002258a04e29ea9ec1a77750ab42

>   src/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstance.java d8a15e07e25ab4148ef147f574d2e5e9b65b8504

>   src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooCache.java 0a3692353ee9e8408d901229f5525152128aa093

>   src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooReader.java 1bcd22b3ab9f1583f1800c20233b49144b8803f9

>   src/core/src/test/java/org/apache/accumulo/core/client/impl/TabletLocatorImplTest.java
624a8243cbbb6a0ed3e0a56519d14818f63836f2 
>   src/server/src/main/java/org/apache/accumulo/server/client/HdfsZooInstance.java d68449d65b2871ba35ba309d2a49c2fccc0f5e61

> 
> Diff: https://reviews.apache.org/r/16187/diff/
> 
> 
> Testing
> -------
> 
> Compile and unit tests pass.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message