accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 16081: ACCUMULO-1958 - Safer Range constructor
Date Mon, 09 Dec 2013 16:18:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16081/
-----------------------------------------------------------

(Updated Dec. 9, 2013, 11:18 a.m.)


Review request for accumulo.


Changes
-------

Added validity checks to Thrift constructor and readFields. Javadoc can be added as part of
ACCUMULO-1931, which is in flight (review: https://reviews.apache.org/r/15857/).


Bugs: ACCUMULO-1958
    https://issues.apache.org/jira/browse/ACCUMULO-1958


Repository: accumulo


Description
-------

Based on Sean's strategy, creates a new protected Range constructor without the start/stop
key check, and adds the check to the public six-argument constructor. Opted not to deprecate
the public constructor at this time, since it is now safe.


Diffs (updated)
-----

  src/core/src/main/java/org/apache/accumulo/core/data/Range.java 7ef0dc5710877cdd0dd3ead69e7db5d8c9ef68c1

  src/core/src/test/java/org/apache/accumulo/core/data/RangeTest.java a8d91b0944cdab6ff10ec0847fe999f0ce666631


Diff: https://reviews.apache.org/r/16081/diff/


Testing
-------

Unit testing for Range still passes.


Thanks,

Bill Havanki


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message