accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <>
Subject Re: Review Request 16081: ACCUMULO-1958 - Safer Range constructor
Date Mon, 09 Dec 2013 16:18:24 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 9, 2013, 11:18 a.m.)

Review request for accumulo.


Added validity checks to Thrift constructor and readFields. Javadoc can be added as part of
ACCUMULO-1931, which is in flight (review:

Bugs: ACCUMULO-1958

Repository: accumulo


Based on Sean's strategy, creates a new protected Range constructor without the start/stop
key check, and adds the check to the public six-argument constructor. Opted not to deprecate
the public constructor at this time, since it is now safe.

Diffs (updated)

  src/core/src/main/java/org/apache/accumulo/core/data/ 7ef0dc5710877cdd0dd3ead69e7db5d8c9ef68c1

  src/core/src/test/java/org/apache/accumulo/core/data/ a8d91b0944cdab6ff10ec0847fe999f0ce666631



Unit testing for Range still passes.


Bill Havanki

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message