accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 16081: ACCUMULO-1958 - Safer Range constructor
Date Fri, 06 Dec 2013 16:33:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16081/#review29880
-----------------------------------------------------------



src/core/src/main/java/org/apache/accumulo/core/data/Range.java
<https://reviews.apache.org/r/16081/#comment57347>

    Please add a javadoc, esp since this now throws an IllegalArgumentException where it previously
did not.



src/core/src/main/java/org/apache/accumulo/core/data/Range.java
<https://reviews.apache.org/r/16081/#comment57348>

    Nit: could we avoid relocating the function within the file so the changeset is smaller?



src/core/src/main/java/org/apache/accumulo/core/data/Range.java
<https://reviews.apache.org/r/16081/#comment57346>

    We need a javadoc here that explains the reasoning for the additional method.
    
    Otherwise, this is going to get blown away in a refactoring because it looks like it's
just a rearrangement of the arg order on Range(Key,Key,boolean,boolean,boolean,boolean)


- Sean Busbey


On Dec. 6, 2013, 4:02 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16081/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 4:02 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1958
>     https://issues.apache.org/jira/browse/ACCUMULO-1958
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Based on Sean's strategy, creates a new protected Range constructor without the start/stop
key check, and adds the check to the public six-argument constructor. Opted not to deprecate
the public constructor at this time, since it is now safe.
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/data/Range.java 7ef0dc5710877cdd0dd3ead69e7db5d8c9ef68c1

> 
> Diff: https://reviews.apache.org/r/16081/diff/
> 
> 
> Testing
> -------
> 
> Unit testing for Range still passes.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message