accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 16043: ACCUMULO-1959 - deprecate a Value constructor
Date Thu, 05 Dec 2013 20:23:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16043/#review29832
-----------------------------------------------------------



core/src/test/java/org/apache/accumulo/core/data/ValueTest.java
<https://reviews.apache.org/r/16043/#comment57310>

    Missing license header and wrong source formatting (might be missing the "apply to new
files,methods, etc" checkbox in Eclipse)


- Josh Elser


On Dec. 5, 2013, 7:55 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16043/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 7:55 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1959
>     https://issues.apache.org/jira/browse/ACCUMULO-1959
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Very minor change, deprecating a constructor for the Value class where a needless double-copy
of the input is performed. I also added a unit test for Value, which really could use one.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/data/Value.java 7d3cf8f20aa12205d25027d6ad06e4a3f6062b2e

>   core/src/test/java/org/apache/accumulo/core/data/ValueTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16043/diff/
> 
> 
> Testing
> -------
> 
> Implemented and ran unit test before and after change, all tests pass.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message