Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 376AE10C31 for ; Thu, 21 Nov 2013 21:32:00 +0000 (UTC) Received: (qmail 98133 invoked by uid 500); 21 Nov 2013 21:32:00 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 98101 invoked by uid 500); 21 Nov 2013 21:32:00 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 98091 invoked by uid 99); 21 Nov 2013 21:32:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Nov 2013 21:32:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BFBB11D377C; Thu, 21 Nov 2013 21:31:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0509913796384989354==" MIME-Version: 1.0 Subject: Re: Review Request 15752: ACCUMULO-1854 Persist AccumuloInputFormat information from Configuration into RangeInputSplit From: "Bill Havanki" To: "Bill Havanki" , "accumulo" , "Josh Elser" Date: Thu, 21 Nov 2013 21:31:55 -0000 Message-ID: <20131121213155.1417.65342@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/15752/ X-Sender: "Bill Havanki" References: <20131121053145.1417.15751@reviews.apache.org> In-Reply-To: <20131121053145.1417.15751@reviews.apache.org> Reply-To: "Bill Havanki" X-ReviewRequest-Repository: accumulo --===============0509913796384989354== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15752/#review29247 ----------------------------------------------------------- src/core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java Thie method no longer needs the conf parameter. And therefore, the method above it taking a TaskAttemptContext parameter doesn't need that either. src/core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java Thie method no longer needs the conf parameter. And therefore, the method above it taking a TaskAttemptContext parameter doesn't need that either. - Bill Havanki On Nov. 21, 2013, 12:31 a.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15752/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 12:31 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1854 > https://issues.apache.org/jira/browse/ACCUMULO-1854 > > > Repository: accumulo > > > Description > ------- > > The current way that AccumuloInputFormat works requires that the same *exact* Configuration that was used to invoke getSplits() is also provided when createRecordReader() is called on the InputFormat. In practice, notably looking at InputFormat implementations which merge or delegate other InputFormats, this is a bad idea. > > By serializing the necessary information into the RangeInputSplit from the provided Configuration object in getSplits() we can completely avoid this problem, at the minimal expense of serialization this information into each InputSplit. I tried to implement the changes in such a way that would be backwards compatible. If the information is not provided (is null) in the RangeInputSplit, the RecordReader will still attempt to pull a value from the Configuration object so as to not fail immediately. This should provide a little more flexibility if users have custom code built on top of the AccumuloInputFormat and RangeInputSplit > > > Diffs > ----- > > src/core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java 4de131f > src/core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java 8e238f1 > src/core/src/main/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplit.java PRE-CREATION > src/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java ba647e9 > src/core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormatTest.java 0673f1b > src/core/src/test/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplitTest.java PRE-CREATION > src/examples/simple/src/test/java/org/apache/accumulo/examples/simple/filedata/ChunkInputFormatTest.java c31c738 > > Diff: https://reviews.apache.org/r/15752/diff/ > > > Testing > ------- > > Verified changes work as intended using PigInputFormat (which may delegate to many InputFormats). Added additional unit tests and verified sufficient coverage using cobertura. > > > Thanks, > > Josh Elser > > --===============0509913796384989354==--