Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============0696595735078676297=="
MIME-Version: 1.0
Subject: Re: Review Request 15481: ACCUMULO-1858 Backport fix for
 ACCUMULO-1379
 PermGen Leak to 1.4 and 1.5
From: "Sean Busbey" <sean@manvsbeard.com>
To: "Bill Havanki" <bhavanki@clouderagovt.com>,
 "Sean Busbey" <sean@manvsbeard.com>, "accumulo" <dev@accumulo.apache.org>
Date: Wed, 13 Nov 2013 19:55:01 -0000
Message-ID: <20131113195501.27766.20547@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sean Busbey" <noreply@reviews.apache.org>
References: <20131113181810.27766.51414@reviews.apache.org>
In-Reply-To: <20131113181810.27766.51414@reviews.apache.org>
Reply-To: "Sean Busbey" <sean@manvsbeard.com>

--===============0696595735078676297==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On Nov. 13, 2013, 6:18 p.m., Bill Havanki wrote:
> > (non-binding) Appears to be a correct backport. The changes to ConditionalWriterTest do not apply, as the test does not appear before 1.6.x.

I should probably note that in the commit message. good catch.


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15481/#review28817
-----------------------------------------------------------


On Nov. 13, 2013, 4:11 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15481/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 4:11 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1858
>     https://issues.apache.org/jira/browse/ACCUMULO-1858
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-1379 Fix edge cases if error in closing ZooKeeperInstance
> 
> (cherry picked from commit 3f6c66ede52cb1fb5a122d7bad06d7978ff0a671)
> 
> Reason: bugfix
> Author: Christopher Tubbs <ctubbsii@apache.org>
> Ref: ACCUMULO-1858
> 
> ACCUMULO-1379 - Adding close() to Instance to assist in freeing up resources
> 
> (cherry picked from commit 7da1164d87227960d3e0cfc841f753067e2c0304)
> 
> Reason: bugfix
> Author: John Vines <jvines@gmail.com>
> Ref: ACCUMULO-1858
> 
> 
> Diffs
> -----
> 
>   src/core/src/main/java/org/apache/accumulo/core/client/Instance.java b3d09ba30b1175a495c9d0cb55b0b4a4f3aadbe1 
>   src/core/src/main/java/org/apache/accumulo/core/client/ZooKeeperInstance.java f657c07a28c3bf330556f0d4e02b9adcb0ea755e 
>   src/core/src/main/java/org/apache/accumulo/core/client/impl/ThriftTransportPool.java ef3724b149921b06cc27945eca11e4d0d1658c6b 
>   src/core/src/main/java/org/apache/accumulo/core/client/mock/MockInstance.java 2ff7b8211de031a4fa04cae3c5bd7a3e03d50506 
>   src/core/src/main/java/org/apache/accumulo/core/util/ThriftUtil.java 1b1cdd735bbf9772dc1a7f82e337125e675aa7b2 
>   src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooCache.java f5bdd6b71652e8e2d664ca2d6480921f11663214 
>   src/core/src/main/java/org/apache/accumulo/core/zookeeper/ZooReader.java 47663acbc421b890bc42bac2d7d5c5556119e6a8 
>   src/core/src/test/java/org/apache/accumulo/core/client/impl/TabletLocatorImplTest.java 538cb6c700423926cd1789654c2933a8ccbb1d65 
>   src/server/src/main/java/org/apache/accumulo/server/client/HdfsZooInstance.java e6cdb6397abe08883dc92700cbe2dc7ce7af6e1a 
> 
> Diff: https://reviews.apache.org/r/15481/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass. Functional tests in progress.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


--===============0696595735078676297==--