Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C962100E4 for ; Thu, 7 Nov 2013 23:57:02 +0000 (UTC) Received: (qmail 77435 invoked by uid 500); 7 Nov 2013 23:57:02 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 77406 invoked by uid 500); 7 Nov 2013 23:57:02 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 77394 invoked by uid 500); 7 Nov 2013 23:57:02 -0000 Delivered-To: apmail-incubator-accumulo-dev@incubator.apache.org Received: (qmail 77384 invoked by uid 99); 7 Nov 2013 23:57:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 23:57:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C15231D3960; Thu, 7 Nov 2013 23:56:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8277982140056867167==" MIME-Version: 1.0 Subject: Re: Review Request 8559: Add Accumulo support to Sqoop From: "Jarek Cecho" To: "Jarek Cecho" Cc: "Philip Grim" , "accumulo" , "Sqoop" Date: Thu, 07 Nov 2013 23:56:58 -0000 Message-ID: <20131107235658.30022.32397@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jarek Cecho" X-ReviewGroup: accumulo, Sqoop X-ReviewRequest-URL: https://reviews.apache.org/r/8559/ X-Sender: "Jarek Cecho" References: <20131105211200.30021.21184@reviews.apache.org> In-Reply-To: <20131105211200.30021.21184@reviews.apache.org> Reply-To: "Jarek Cecho" --===============8277982140056867167== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/#review28271 ----------------------------------------------------------- Hi Philip, I do have couple of nits: src/docs/user/accumulo.txt Nit: I believe that there is missing dash in the "--accumulo password" parameter? src/java/org/apache/sqoop/SqoopOptions.java Nit: Unnecessary // src/java/org/apache/sqoop/SqoopOptions.java Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/SqoopOptions.java Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/SqoopOptions.java Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/SqoopOptions.java Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/accumulo/AccumuloUtil.java Nit: Can we put the class name into constant? src/java/org/apache/sqoop/tool/BaseSqoopTool.java Nit: Wouldn't be simpler to verify that FileLayout have to be the default one rather then verifying every other possibility? src/java/org/apache/sqoop/tool/BaseSqoopTool.java Would it be valid situation for the password to be missing? Jarcec - Jarek Cecho On Nov. 5, 2013, 9:11 p.m., Philip Grim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8559/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 9:11 p.m.) > > > Review request for accumulo, Sqoop and Jarek Cecho. > > > Repository: sqoop-trunk > > > Description > ------- > > Adds the ability to import to an Accumulo table in much the same manner as the current HBase import capability. Reported in JIRA as ACCUMULO-141 and SQOOP-767. > > > Diffs > ----- > > ivy.xml c5130ae > src/docs/user/accumulo-args.txt PRE-CREATION > src/docs/user/accumulo.txt PRE-CREATION > src/java/org/apache/sqoop/SqoopOptions.java 5c7a56a > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java PRE-CREATION > src/java/org/apache/sqoop/manager/SqlManager.java 1ffa40f > src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 018d11f > src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d > src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION > > Diff: https://reviews.apache.org/r/8559/diff/ > > > Testing > ------- > > > Thanks, > > Philip Grim > > --===============8277982140056867167==--