Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 378161066C for ; Wed, 6 Nov 2013 20:00:43 +0000 (UTC) Received: (qmail 52319 invoked by uid 500); 6 Nov 2013 20:00:43 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 52292 invoked by uid 500); 6 Nov 2013 20:00:43 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 52283 invoked by uid 500); 6 Nov 2013 20:00:43 -0000 Delivered-To: apmail-incubator-accumulo-dev@incubator.apache.org Received: (qmail 52275 invoked by uid 99); 6 Nov 2013 20:00:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 20:00:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7EDCB1D3905; Wed, 6 Nov 2013 20:00:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7104046050279835126==" MIME-Version: 1.0 Subject: Re: Review Request 15279: ACCUMULO-1556: Clarify initialization error messages for pre-initialized filesystem From: "John Vines" To: "John Vines" , "Bill Havanki" , "accumulo" Date: Wed, 06 Nov 2013 20:00:39 -0000 Message-ID: <20131106200039.30021.46517@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Vines" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/15279/ X-Sender: "John Vines" References: <20131106190203.30021.19399@reviews.apache.org> In-Reply-To: <20131106190203.30021.19399@reviews.apache.org> Reply-To: "John Vines" --===============7104046050279835126== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15279/#review28296 ----------------------------------------------------------- Ship it! Ship It! - John Vines On Nov. 6, 2013, 7:02 p.m., Bill Havanki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15279/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2013, 7:02 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1556 > https://issues.apache.org/jira/browse/ACCUMULO-1556 > > > Repository: accumulo > > > Description > ------- > > The Initialize class now generates clearer error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. > > Note that to facilitate unit testing, the verification logic in Initialize.doInit() was refactored into a checkInit() method. > > > Diffs > ----- > > pom.xml 9ed2fdf1c7a1f8831667b27bfaa307fbe2467fe8 > src/server/pom.xml 6421bc69cda5116f9716d30adc3d510baa3bb7d6 > src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java 51576fcc8ff8ffcd65a78bfeaaaf51036360a6bc > src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/15279/diff/ > > > Testing > ------- > > Ran initialization with patch changes on 1.4.3 cluster under CDH 4.3. Tested successful initialization and correct emission of error messages when instance.dfs.uri was used and was not used. Also, implemented unit tests for altered code. > > > Thanks, > > Bill Havanki > > --===============7104046050279835126==--