accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ted Yu <yuzhih...@gmail.com>
Subject Re: ReviewBoard
Date Fri, 15 Nov 2013 02:42:30 GMT
bq. getting an error and losing your unpublished comments from the previous
page.

This happened to me recently. I refreshed the previous page and got my
comments back.

Cheers


On Thu, Nov 14, 2013 at 6:31 PM, Christopher <ctubbsii@apache.org> wrote:

> 3 things:
>
> #1
> ReviewBoard has been really buggy lately. Has anybody else noticed this?
>
> Examples: errors when publishing a review, but review still gets
> published, or moving to a second page on a diff, during a review, but
> getting an error and losing your unpublished comments from the
> previous page.
>
> #2
> I've noticed that ReviewBoard is being used more frequently lately,
> and for tiny, relatively trivial patches. ReviewBoard is great (when
> it's working), but I'm not sure it is strictly necessary to submit all
> contributed patches to ReviewBoard. It's fine if you wish to use it (I
> don't want to discourage it)... but I just don't want contributors
> getting the impression that it's a requirement.
>
> #3
> Don't forget to close out your reviews after the patch has been applied.
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message