accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 15846: Prototype implementation of ACCUMULO-1787.
Date Tue, 26 Nov 2013 14:32:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15846/#review29433
-----------------------------------------------------------



server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java
<https://reviews.apache.org/r/15846/#comment56649>

    Bulk imported files may not have an estimated size.  I can not remember, something to
look into.



server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java
<https://reviews.apache.org/r/15846/#comment56650>

    The following situation is kinda bugging me, but I do not think its very important.
    
    1. some snappy files exceed threshold 
    2. creates a gzip file thats below threshold
    3. forced compaction of that gzip file creates a snappy file
    
    
    
    


- kturner


On Nov. 26, 2013, 4:32 a.m., Chris McCubbin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15846/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 4:32 a.m.)
> 
> 
> Review request for accumulo, Adam Fuchs, Josh Elser, and kturner.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> This is a prototype implementation of ACCUMULO-1787.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java f4c1778 
>   server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java 8e4af64

> 
> Diff: https://reviews.apache.org/r/15846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris McCubbin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message