accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Fuchs" <afu...@apache.org>
Subject Re: Review Request 15846: Prototype implementation of ACCUMULO-1787.
Date Mon, 25 Nov 2013 21:52:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15846/#review29395
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/15846/#comment56597>

    Whitespace changes should be removed.



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/15846/#comment56599>

    Instead of specifying the compression threshold as a count in "millions of bytes" it should
use PropertyType.MEMORY.



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/15846/#comment56603>

    We need a way to determine whether this option has been enabled, and configuration should
default to the previous behavior if this is not enabled. This could be done with a file compression
threshold of 0B, and then the alternative compression type would be for small files instead
of large files.



server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java
<https://reviews.apache.org/r/15846/#comment56606>

    This should only be done if the alternative compression type is enabled. If we default
the threshold to 0B and flip the > to a < that would be sufficient.


- Adam Fuchs


On Nov. 25, 2013, 9:37 p.m., Chris McCubbin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15846/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 9:37 p.m.)
> 
> 
> Review request for accumulo, Adam Fuchs, Josh Elser, and kturner.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> This is a prototype implementation of ACCUMULO-1787.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java f4c1778 
>   server/src/main/java/org/apache/accumulo/server/tabletserver/Compactor.java 8e4af64

> 
> Diff: https://reviews.apache.org/r/15846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris McCubbin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message