accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 8559: Add Accumulo support to Sqoop
Date Wed, 20 Nov 2013 19:01:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8559/#review29173
-----------------------------------------------------------

Ship it!


Hi Philip,
I was able to test the code on my Accumulo 1.5 cluster, good job! Thank you very much for
following up through all the review rounds, I appreciate your patience! I do have couple of
small final nits, so please fix those and upload the patch to the JIRA. I'll commit it shortly
after that!


src/java/org/apache/sqoop/accumulo/AccumuloUtil.java
<https://reviews.apache.org/r/8559/#comment56313>

    Nit: The return here is not relevant, right? Can we either put the "return" to the previous
if-branch as well or remove it from here? It will be easier for others to see the similar
code then wondering why there is a return on one place and not on the another :-)



src/java/org/apache/sqoop/accumulo/AccumuloUtil.java
<https://reviews.apache.org/r/8559/#comment56314>

    Nit: Trailing white space.



bin/configure-sqoop
<https://reviews.apache.org/r/8559/#comment56322>

    Since we are using the environment variable ACCUMULO_HOME in the JAVA application, we
need to export it here. Otherwise it won't get propagated.



src/java/org/apache/sqoop/accumulo/AccumuloUtil.java
<https://reviews.apache.org/r/8559/#comment56321>

    Nit: Trailing white space


Jarcec

- Jarek Cecho


On Nov. 19, 2013, 11:06 p.m., Philip Grim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8559/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 11:06 p.m.)
> 
> 
> Review request for accumulo, Sqoop and Jarek Cecho.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Adds the ability to import to an Accumulo table in much the same manner as the current
HBase import capability.  Reported in JIRA as ACCUMULO-141 and SQOOP-767.
> 
> 
> Diffs
> -----
> 
>   bin/configure-sqoop e604197 
>   bin/configure-sqoop.cmd ec57e37 
>   ivy.xml c5130ae 
>   src/docs/user/accumulo-args.txt PRE-CREATION 
>   src/docs/user/accumulo.txt PRE-CREATION 
>   src/docs/user/import.txt dfc9b39 
>   src/docs/user/validation.txt 282cfd6 
>   src/java/org/apache/sqoop/SqoopOptions.java 5c7a56a 
>   src/java/org/apache/sqoop/accumulo/AccumuloConstants.java PRE-CREATION 
>   src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java PRE-CREATION 
>   src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION 
>   src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION 
>   src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java PRE-CREATION 
>   src/java/org/apache/sqoop/manager/SqlManager.java 1ffa40f 
>   src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 018d11f 
>   src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d 
>   src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java PRE-CREATION 
>   src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8559/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Philip Grim
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message