accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubb...@apache.org>
Subject Re: Review Request 15518: ACCUMULO-1878 handle error conditions in example tests.
Date Sat, 16 Nov 2013 01:18:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15518/#review29005
-----------------------------------------------------------

Ship it!


Ship It!

- Christopher Tubbs


On Nov. 15, 2013, 1:42 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15518/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 1:42 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1878
>     https://issues.apache.org/jira/browse/ACCUMULO-1878
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-1878 handle error conditions in example tests.
> 
> * ensure simple examples used in integration tests properly set non-zero exit on errors
> * check return code of executed commands.
> * fix typo in bloom filter speed comparison
> * fix error in arg order on helloworld examples
> * Makes sure paired examples for RandomBatch use the same seed.
> 
> 
> Diffs
> -----
> 
>   src/examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java
7801104bf5b8095066630512a0b44bc8af2a85bf 
>   test/system/auto/simple/examples.py 5fc9b4bdee7f24beba0d85f414600afffa8d0b08 
> 
> Diff: https://reviews.apache.org/r/15518/diff/
> 
> 
> Testing
> -------
> 
> unit tests pass. functional test simple.examples.Examples passes, presuming the fixes
for ACCUMULO-1891 and ACCUMULO-1892 are in place.
> 
> I get rare on-VM flakiness on the bloom filter /no bloom speed comparison.
> 
> I was getting loud failure on the non-isolated scanner interference example, but it mysteriously
stopped happening. I presume it was VM related. I have stack traces still, so I could file
a follow on ticket if there's interest.
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message