accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@clouderagovt.com>
Subject Re: Review Request 15279: ACCUMULO-1556: Clarify initialization error messages for pre-initialized filesystem
Date Wed, 06 Nov 2013 20:29:34 GMT


> On Nov. 6, 2013, 2:49 p.m., Sean Busbey wrote:
> > src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java, lines
23-25
> > <https://reviews.apache.org/r/15279/diff/1/?file=379597#file379597line23>
> >
> >     please don't include formatting fixes unrelatd to the change.
> 
> Bill Havanki wrote:
>     The Eclipse code formatter insisted, and I'm told we should use it.
> 
> Sean Busbey wrote:
>     Break into another issue/patch then please.
> 
> John Vines wrote:
>     For code you introduce, sure. I wouldn't worry yourself with it here. There is an
eclipse option to only format lines you modify.

Sounds good. I'll revert these two bits.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15279/#review28290
-----------------------------------------------------------


On Nov. 6, 2013, 2:02 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15279/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 2:02 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1556
>     https://issues.apache.org/jira/browse/ACCUMULO-1556
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> The Initialize class now generates clearer error messages if an initialized instance
is discovered. The messages vary depending on whether instance.dfs.uri is used.
> 
> Note that to facilitate unit testing, the verification logic in Initialize.doInit() was
refactored into a checkInit() method.
> 
> 
> Diffs
> -----
> 
>   pom.xml 9ed2fdf1c7a1f8831667b27bfaa307fbe2467fe8 
>   src/server/pom.xml 6421bc69cda5116f9716d30adc3d510baa3bb7d6 
>   src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java 51576fcc8ff8ffcd65a78bfeaaaf51036360a6bc

>   src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/15279/diff/
> 
> 
> Testing
> -------
> 
> Ran initialization with patch changes on 1.4.3 cluster under CDH 4.3. Tested successful
initialization and correct emission of error messages when instance.dfs.uri was used and was
not used. Also, implemented unit tests for altered code.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message