Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 52C001097D for ; Tue, 29 Oct 2013 16:27:57 +0000 (UTC) Received: (qmail 90678 invoked by uid 500); 29 Oct 2013 16:27:56 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 90557 invoked by uid 500); 29 Oct 2013 16:27:54 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 90533 invoked by uid 500); 29 Oct 2013 16:27:52 -0000 Delivered-To: apmail-incubator-accumulo-dev@incubator.apache.org Received: (qmail 90513 invoked by uid 99); 29 Oct 2013 16:27:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2013 16:27:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5067F1D37E4; Tue, 29 Oct 2013 16:27:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2345709419508417421==" MIME-Version: 1.0 Subject: Re: Review Request 15002: ACCUMULO-1307 - adds flag to prompt fate threads to end From: "Bill Havanki" To: "John Vines" , "Bill Havanki" , "accumulo" Date: Tue, 29 Oct 2013 16:27:49 -0000 Message-ID: <20131029162749.7402.44389@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Havanki" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/15002/ X-Sender: "Bill Havanki" References: <20131029155225.7402.46257@reviews.apache.org> In-Reply-To: <20131029155225.7402.46257@reviews.apache.org> Reply-To: "Bill Havanki" --===============2345709419508417421== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15002/#review27689 ----------------------------------------------------------- This is really crying out to be implemented using thread interruption instead of a flag check. However, it looks like the ZooStore implementation wouldn't deal with InterruptedExceptions well. - Bill Havanki On Oct. 29, 2013, 11:52 a.m., John Vines wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15002/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2013, 11:52 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1307 > https://issues.apache.org/jira/browse/ACCUMULO-1307 > > > Repository: accumulo > > > Description > ------- > > First pass at shutting down FATE. Maybe makes sense to daemonize the thread and add a daemonized monitor thread that 'manages' them somehow in case operation is stuck? > > > Diffs > ----- > > fate/src/main/java/org/apache/accumulo/fate/Fate.java bd36edb > server/src/main/java/org/apache/accumulo/server/master/Master.java c029ae5 > > Diff: https://reviews.apache.org/r/15002/diff/ > > > Testing > ------- > > > Thanks, > > John Vines > > --===============2345709419508417421==--