Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 77330108BC for ; Tue, 29 Oct 2013 16:09:05 +0000 (UTC) Received: (qmail 33652 invoked by uid 500); 29 Oct 2013 16:08:57 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 33616 invoked by uid 500); 29 Oct 2013 16:08:56 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 33588 invoked by uid 500); 29 Oct 2013 16:08:54 -0000 Delivered-To: apmail-incubator-accumulo-dev@incubator.apache.org Received: (qmail 33527 invoked by uid 99); 29 Oct 2013 16:08:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2013 16:08:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 83E111D37E4; Tue, 29 Oct 2013 16:08:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6038967192867609181==" MIME-Version: 1.0 Subject: Re: Review Request 15002: ACCUMULO-1307 - adds flag to prompt fate threads to end From: "Mike Drob" To: "John Vines" , "Mike Drob" , "accumulo" Date: Tue, 29 Oct 2013 16:08:51 -0000 Message-ID: <20131029160851.7400.8697@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mike Drob" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/15002/ X-Sender: "Mike Drob" References: <20131029155225.7402.46257@reviews.apache.org> In-Reply-To: <20131029155225.7402.46257@reviews.apache.org> Reply-To: "Mike Drob" --===============6038967192867609181== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15002/#review27686 ----------------------------------------------------------- fate/src/main/java/org/apache/accumulo/fate/Fate.java Is an eventual stop good enough? Do we want some logic to preempt the currently running fate operations? fate/src/main/java/org/apache/accumulo/fate/Fate.java Javadoc, please. server/src/main/java/org/apache/accumulo/server/master/Master.java If you're addressing this TODO, can you remove it from the code? - Mike Drob On Oct. 29, 2013, 3:52 p.m., John Vines wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15002/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2013, 3:52 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1307 > https://issues.apache.org/jira/browse/ACCUMULO-1307 > > > Repository: accumulo > > > Description > ------- > > First pass at shutting down FATE. Maybe makes sense to daemonize the thread and add a daemonized monitor thread that 'manages' them somehow in case operation is stuck? > > > Diffs > ----- > > fate/src/main/java/org/apache/accumulo/fate/Fate.java bd36edb > server/src/main/java/org/apache/accumulo/server/master/Master.java c029ae5 > > Diff: https://reviews.apache.org/r/15002/diff/ > > > Testing > ------- > > > Thanks, > > John Vines > > --===============6038967192867609181==--