Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1AF1F10832 for ; Tue, 29 Oct 2013 15:56:09 +0000 (UTC) Received: (qmail 96425 invoked by uid 500); 29 Oct 2013 15:53:47 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 96328 invoked by uid 500); 29 Oct 2013 15:53:36 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 96132 invoked by uid 500); 29 Oct 2013 15:53:08 -0000 Delivered-To: apmail-incubator-accumulo-dev@incubator.apache.org Received: (qmail 95645 invoked by uid 99); 29 Oct 2013 15:52:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2013 15:52:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DC5171D37E4; Tue, 29 Oct 2013 15:52:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0687652358848149291==" MIME-Version: 1.0 Subject: Re: Review Request 15002: ACCUMULO-1307 - adds flag to prompt fate threads to end From: "John Vines" To: "John Vines" , "Eric Newton" , "accumulo" Date: Tue, 29 Oct 2013 15:52:25 -0000 Message-ID: <20131029155225.7402.46257@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Vines" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/15002/ X-Sender: "John Vines" References: <20131028225436.7399.76649@reviews.apache.org> In-Reply-To: <20131028225436.7399.76649@reviews.apache.org> Reply-To: "John Vines" --===============0687652358848149291== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15002/ ----------------------------------------------------------- (Updated Oct. 29, 2013, 3:52 p.m.) Review request for accumulo. Changes ------- Updated patch which used an AtomicBoolean to prevent overly helpful caching from causing undesired behavior Bugs: ACCUMULO-1307 https://issues.apache.org/jira/browse/ACCUMULO-1307 Repository: accumulo Description ------- First pass at shutting down FATE. Maybe makes sense to daemonize the thread and add a daemonized monitor thread that 'manages' them somehow in case operation is stuck? Diffs (updated) ----- fate/src/main/java/org/apache/accumulo/fate/Fate.java bd36edb server/src/main/java/org/apache/accumulo/server/master/Master.java c029ae5 Diff: https://reviews.apache.org/r/15002/diff/ Testing ------- Thanks, John Vines --===============0687652358848149291==--