accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x)
Date Thu, 31 Oct 2013 16:11:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/#review27905
-----------------------------------------------------------

Ship it!


Looks good to me. One way or the other, lets make sure a README update happens like Sean suggests.

- Josh Elser


On Oct. 30, 2013, 2:26 p.m., Bill Havanki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15096/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2013, 2:26 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1829
>     https://issues.apache.org/jira/browse/ACCUMULO-1829
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Slower hardware or VMs may have trouble completing tests within the timeouts specified.
This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests,
the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness
and ZooCacheTest.
> 
> Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The
additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
> 
> 
> Diffs
> -----
> 
>   test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a 
>   test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36 
>   test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823 
>   test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd

>   test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7 
> 
> Diff: https://reviews.apache.org/r/15096/diff/
> 
> 
> Testing
> -------
> 
> Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with
no added factor, but all pass with -f 4.
> 
> 
> Thanks,
> 
> Bill Havanki
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message