accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines" <vi...@apache.org>
Subject Re: Review Request 14995: ACCUMULO-1679 - Purges TFile by rolling the two static calls into BCFile
Date Tue, 29 Oct 2013 21:11:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14995/
-----------------------------------------------------------

(Updated Oct. 29, 2013, 9:11 p.m.)


Review request for accumulo.


Changes
-------

Fixed random TODO in javadoc.
Shifted former tfile constants and helper methods to be colocated and private


Bugs: ACCUMULO-1679
    https://issues.apache.org/jira/browse/ACCUMULO-1679


Repository: accumulo


Description
-------

Dirt simple fix which moves the 2 static variables and methods into BCFile. I'm pretty sure
we can't go about renaming those constants, but I could be mistaken. General trivialness of
this fix is why I'm review boarding it - it seems too easy.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java 2d9f6af 
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Chunk.java a075d87 
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java e89bb40 
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFile.java f2cb326 
  core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFileDumper.java d5b0a1b 

Diff: https://reviews.apache.org/r/14995/diff/


Testing
-------


Thanks,

John Vines


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message