accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 15002: ACCUMULO-1307 - adds flag to prompt fate threads to end
Date Tue, 29 Oct 2013 16:08:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15002/#review27686
-----------------------------------------------------------



fate/src/main/java/org/apache/accumulo/fate/Fate.java
<https://reviews.apache.org/r/15002/#comment53777>

    Is an eventual stop good enough? Do we want some logic to preempt the currently running
fate operations?



fate/src/main/java/org/apache/accumulo/fate/Fate.java
<https://reviews.apache.org/r/15002/#comment53776>

    Javadoc, please.



server/src/main/java/org/apache/accumulo/server/master/Master.java
<https://reviews.apache.org/r/15002/#comment53775>

    If you're addressing this TODO, can you remove it from the code?


- Mike Drob


On Oct. 29, 2013, 3:52 p.m., John Vines wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15002/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2013, 3:52 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1307
>     https://issues.apache.org/jira/browse/ACCUMULO-1307
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> First pass at shutting down FATE. Maybe makes sense to daemonize the thread and add a
daemonized monitor thread that 'manages' them somehow in case operation is stuck?
> 
> 
> Diffs
> -----
> 
>   fate/src/main/java/org/apache/accumulo/fate/Fate.java bd36edb 
>   server/src/main/java/org/apache/accumulo/server/master/Master.java c029ae5 
> 
> Diff: https://reviews.apache.org/r/15002/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Vines
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message