accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki" <bhava...@cloudera.com>
Subject Re: Review Request 14995: ACCUMULO-1679 - Purges TFile by rolling the two static calls into BCFile
Date Mon, 28 Oct 2013 18:46:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14995/#review27625
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java
<https://reviews.apache.org/r/14995/#comment53667>

    How about defining a new attribute "bcfile.fs.output.buffer.size" which can be primarily
used, with "tfile" as a fallback for compatibility? (Ditto for the input buffer.) Leaving
the tfile ones there will just be confusing after a while.


- Bill Havanki


On Oct. 28, 2013, 1:55 p.m., John Vines wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14995/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 1:55 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1679
>     https://issues.apache.org/jira/browse/ACCUMULO-1679
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Dirt simple fix which moves the 2 static variables and methods into BCFile. I'm pretty
sure we can't go about renaming those constants, but I could be mistaken. General trivialness
of this fix is why I'm review boarding it - it seems too easy.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java 2d9f6af 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java e89bb40

>   core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFile.java f2cb326 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFileDumper.java d5b0a1b

> 
> Diff: https://reviews.apache.org/r/14995/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John Vines
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message