accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 14880: ACCUMULO-1785 Alter config.sh to optionally just verify environment instead of making changes
Date Wed, 23 Oct 2013 21:53:14 GMT


> On Oct. 23, 2013, 8:40 p.m., Christopher Tubbs wrote:
> > bin/config.sh, lines 139-142
> > <https://reviews.apache.org/r/14880/diff/1/?file=369928#file369928line139>
> >
> >     This looks like it will spit stuff to STDERR if masters file isn't there and
ACCUMULO_VERIFY_ONLY is set, and won't set GC.

Right, it will output a message to stderr that CONF_DIR/masters doesn't exist. Should I suppress
that message?

It will still set GC if it is not set (provided CONF_DIR/gc exists)


> On Oct. 23, 2013, 8:40 p.m., Christopher Tubbs wrote:
> > bin/config.sh, lines 147-149
> > <https://reviews.apache.org/r/14880/diff/1/?file=369928#file369928line147>
> >
> >     Can this still happen if ACCUMULO_VERIFY_ONLY is set and no masters file exists?

yes. CONF_DIR/gc still gets loaded if it exists. if GC was set, none of this would be checked
at all.

If none of those are true, config.sh will exit with non-zero status to indicate an error.


> On Oct. 23, 2013, 8:40 p.m., Christopher Tubbs wrote:
> > bin/config.sh, lines 152-159
> > <https://reviews.apache.org/r/14880/diff/1/?file=369928#file369928line152>
> >
> >     Same issue with GC not being set applies to MONITOR not being set and can't
be set from master if ACCUMULO_VERIFY_ONLY is set and no masters file.

if there was no masters file, and no monitor file, and MONITOR wasn't set, the script will
exist with non-zero status.


> On Oct. 23, 2013, 8:40 p.m., Christopher Tubbs wrote:
> > bin/config.sh, line 42
> > <https://reviews.apache.org/r/14880/diff/1/?file=369928#file369928line42>
> >
> >     This should be a separate commit

broken out into ACCUMULO-1810


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14880/#review27417
-----------------------------------------------------------


On Oct. 23, 2013, 7:08 p.m., Sean Busbey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14880/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2013, 7:08 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-1785
>     https://issues.apache.org/jira/browse/ACCUMULO-1785
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Updates config.sh to skip automagic standalone mode and avoid writing to the local filesystem
given an optional environment variable. Adds additional error handling since this changes
the invariant that a conf/masters file will exist.
> 
> 
> Diffs
> -----
> 
>   bin/config.sh 9277406 
> 
> Diff: https://reviews.apache.org/r/14880/diff/
> 
> 
> Testing
> -------
> 
> functional tests
> starting w/o env variable set and no master/slaves correctly started in standalone mode.
> starting w/env variable and no required variables and no master/slaves correctly complained
and failed.
> starting w/env variable and required variables and no master/slaves correctly init w/o
writing crap, correctly failed to use start-all
> starting with a normal cluster config
> 
> 
> Thanks,
> 
> Sean Busbey
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message