Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Received-SPF: pass (athena.apache.org: domain of bhavanki@cloudera.com
 designates 74.125.82.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAL5zq9aPKwHZTkzUBmQ4VE8MxTZjhsV3qT+FFTSCNwQ=Edt2oA@mail.gmail.com>
References: <523FAA79.6000803@gmail.com>
 <CAL5zq9ZWtyHT2=qN0WDvZ5o+cLTM=-MuZ1eTNAQZGHqrLYaE6A@mail.gmail.com>
 <CAGUtCHr4w50dC4yxvf5-7HaF-5M8rr-_vzDPXh0DxkDFxgLUkg@mail.gmail.com>
 <CAL5zq9aPKwHZTkzUBmQ4VE8MxTZjhsV3qT+FFTSCNwQ=Edt2oA@mail.gmail.com>
From: Bill Havanki <bhavanki@cloudera.com>
Date: Wed, 25 Sep 2013 17:24:31 -0400
Message-ID: 
 <CADaF5=Hkmk6EPu6R1-fXPQTMtyk-rEYkZVHA8Y5U7jZEbYBCbg@mail.gmail.com>
Subject: Re: [VOTE] Accumulo Instamo Archetype 1.4.4 RC2
To: dev@accumulo.apache.org
Content-Type: multipart/alternative; boundary=089e0102e6da3eb84c04e73be27b

--089e0102e6da3eb84c04e73be27b
Content-Type: text/plain; charset=ISO-8859-1

The #set directives define escapes for special characters (I just found
this out). See the section "Escape special characters" at:

https://community.jboss.org/wiki/MavenArchetypeCreationGuidelines?_sscc=t

The escapes only need to be there if they are used. It looks like
MapReduceExample.java uses only symbol_escape, and the rest are not needed
- but harmless to remain.


On Wed, Sep 25, 2013 at 3:45 PM, Christopher <ctubbsii@apache.org> wrote:

> #5, #6, and #7 need to be fixed. #1, #2, and #8 are trivial to fix
> while addressing the others.
>
> #3 only needs to be fixed if the missing ones are important.. but I
> don't really know what they're for.
>
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
>
> On Wed, Sep 25, 2013 at 3:37 PM, Keith Turner <keith@deenlo.com> wrote:
> > On Wed, Sep 25, 2013 at 3:10 PM, Christopher <ctubbsii@apache.org>
> wrote:
> >
> >> MD5s and SHA1s look good, and so does the GPG signatures.
> >>
> >> I saw the following issues:
> >>
> >> 1) No javadoc jar (should be defined in the "apache-release" profile).
> >> 2) Tarball looks like it isn't using gnu tar format. This could cause
> >> problems with long filenames on some systems. You need the following
> >> in your pluginManagement section:
> >>         <plugin>
> >>           <groupId>org.apache.maven.plugins</groupId>
> >>           <artifactId>maven-assembly-plugin</artifactId>
> >>           <configuration>
> >>             <tarLongFileMode>gnu</tarLongFileMode>
> >>           </configuration>
> >>         </plugin>
> >> (I really don't know why that isn't the default. This might be
> >> addressed with the "apache-release" profile)
> >> 3) What's the deal with the #set lines at the top of the file? What do
> >> these do? Are these needed? Because ShellExample.java is missing them.
> >> Is that expected?
> >> 4) There appears to be two distinct READMEs. Would it be better to
> >> consolidate them?
> >>
> >
> > I think not.  One is directed to someone building the archetype and one
> to
> > someone using the archetype. I think it saves end users time to split
> them.
> >
> >
> >> 5) There appears to be a discrepancy between the LICENSE and NOTICE
> >> files that are in the project and the archetype-resources. I'd expect
> >> them to be the same.
> >> 6) I can't see the commit you referenced above, because it hasn't been
> >> pushed. You should push it in another branch, if you don't want to tag
> >> it, so I can compare the source in that commit with the contents of
> >> the tarball, before it's actually tagged as "1.4.4" upon vote success.
> >> 7) It looks like the release plugin put in the wrong tag name
> >> ("1.4.4-RC2" instead of "1.4.4").
> >> 8) I think the attaching sources is redundant, because it's configured
> >> in the parent POM's "apache-release" profile.
> >>
> >> Overall, -1, due to the above issues (though they are all minor, they
> add
> >> up).
> >>
> >
> > Which issues do you think must be fixed?
> >
> >
> >>
> >> --
> >> Christopher L Tubbs II
> >> http://gravatar.com/ctubbsii
> >>
> >>
> >> On Sun, Sep 22, 2013 at 10:42 PM, Josh Elser <josh.elser@gmail.com>
> wrote:
> >> > Devs,
> >> >
> >> > Please consider the following candidate project as a "sister" release
> to
> >> > Apache Accumulo 1.4.4: Apache Accumulo Instamo Archetype 1.4.4
> >> >
> >> > Staging repo:
> >> >
> >>
> https://repository.apache.org/content/repositories/orgapacheaccumulo-089/
> >> > Source tarball:
> >> >
> >>
> https://repository.apache.org/content/repositories/orgapacheaccumulo-089/org/apache/accumulo/instamo-archetype/1.4.4/instamo-archetype-1.4.4-source-release.tar.gz
> >> > Git tag: 56e3c674674dc2521a76dce2466360b1f82ca0ea (1.4.4-RC2)
> >> >
> >> > This release has improvements over the last release candidate:
> >> >
> >> > 1) Update archetype's pom to the most recent Apache pom
> >> > 2) Generates source-release zip and tarball automatically
> >> > 3) Don't push changes on release:prepare
> >> >
> >> > This vote is open for 72hrs.
> >> >
> >> > - Josh
> >>
>

--089e0102e6da3eb84c04e73be27b--