Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Received-SPF: pass (athena.apache.org: domain of cjnolet@gmail.com designates
 209.85.223.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <51EDC275.8080402@gmail.com>
References: 
 <CAALcEpgdeiVak5_joqnNpZ3LJMZjKxX44_xSVsFkkXew9L_Kaw@mail.gmail.com>
	<51EDC275.8080402@gmail.com>
Date: Mon, 22 Jul 2013 20:02:00 -0400
Message-ID: 
 <CAOHP_tH9nsfCm06ZTW_7tt30pJjo5Zecgq93MB49v4FG22LdXQ@mail.gmail.com>
Subject: Re: Thrift generated files
From: Corey Nolet <cjnolet@gmail.com>
To: "dev@accumulo.apache.org" <dev@accumulo.apache.org>
Content-Type: multipart/alternative; boundary=047d7bdca46c8e089504e2228087

--047d7bdca46c8e089504e2228087
Content-Type: text/plain; charset=ISO-8859-1

bq. do we have to copy the generated file in to source code and commit?

I believe the script that generates the thrift files also diffs them
against the working tree and copies any changes where they go. At that
point, you should just be able to stage them for a commit.


On Mon, Jul 22, 2013 at 7:38 PM, Josh Elser <josh.elser@gmail.com> wrote:

> AFAIK, that's correct. Change the thrift definition and commit the new
> generated file.
>
>
> On 07/22/2013 07:27 PM, Supun Kamburugamuva wrote:
>
>> Hi all,
>>
>> I have a question about the thrift file generation. I can see you are
>> generating the java classes from the thrift files. If we change a thrift
>> file do we have to copy the generated file in to source code and commit?
>> I'm bit confused about the work-flow.
>>
>> Thanks,
>> Supun..
>>
>>

--047d7bdca46c8e089504e2228087--