Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Received-SPF: pass (nike.apache.org: domain of eric.newton@gmail.com
 designates 209.85.212.172 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAL5zq9YERBvRWa9_UNiT1LJYWLzgpwkXTmTmv=+iiCyMLA7A+A@mail.gmail.com>
References: 
 <CAA+ACqecEOhEz4-gGgpNOSYUzHy92CmcshqWSSEwtwVM2KsqVw@mail.gmail.com>
	<CAL5zq9YERBvRWa9_UNiT1LJYWLzgpwkXTmTmv=+iiCyMLA7A+A@mail.gmail.com>
Date: Tue, 23 Jul 2013 13:11:37 -0400
Message-ID: 
 <CADxc9BnMOYP8QUpYMrydCAJHY3va7+ASXQrTLa=Vffv1unFiKA@mail.gmail.com>
Subject: Re: Config in ZooKeeperInstance
From: Eric Newton <eric.newton@gmail.com>
To: dev@accumulo.apache.org
Content-Type: multipart/alternative; boundary=089e013c63e8bf29f704e230e2f8

--089e013c63e8bf29f704e230e2f8
Content-Type: text/plain; charset=ISO-8859-1

+1 for removing it from Instance


On Tue, Jul 23, 2013 at 12:14 PM, Christopher <ctubbsii@apache.org> wrote:

> It only returns the default config if you don't call
> setConfiguration(), which appears to be almost always (except
> TestIngest).
>
> I don't know that this API is clearly spelled out, as to its intended
> purpose. Which configuration is it supposed to be getting, and how
> does that relate to the ZooKeeperInstance? The only configuration a
> ZooKeeperInstance has is the minimum needed to connect to other
> servers. It still has to authenticate to read any other server
> configuration.
>
> Personally, I'd be in favor of removing it from Instance interface,
> unless we actually document what it is supposed to be for to justify
> its utility in, and relationship to, the Instance interface.
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
>
> On Tue, Jul 23, 2013 at 10:44 AM, Michael Berman <mberman@sqrrl.com>
> wrote:
> > I was surprised to find that ZooKeeperInstance.getConfiguration() seems
> to
> > return only the default configuration rather than the configuration
> stored
> > in ZK.  Is this the expected behavior?  I came across this in a MacTest,
> so
> > if other people are also surprised, it may be a MAC or MacTest-specific
> > issue, in which case I'm happy to track it down.
> >
> > If this is currently the expected behavior, how would people feel about
> > changing it?  It seems like it would be useful to have a config channel
> to
> > ZooKeeperInstance clients (in my case, what I'm specifically interested
> in
> > is whether or not SSL is enabled).  There may be a potential for
> privileged
> > information to escape...table settings, for example, may be sensitive...
> > But all the really secret stuff should be in the site.xml which wouldn't
> > get exposed.
> >
> > For reference, ZooKeeperInstance's getConfiguration() is implemented as:
> > AccumuloConfiguration.getDefaultConfiguration()
> >
> > whereas HdfsZooInstance's getConfiguration() is:
> > ZooConfiguration.getInstance(this, getSiteConfiguration())
> >
> > My proposal would be to change ZooKeeperInstance's to something like:
> > ZooConfiguration.getInstance(this,
> > AccumuloConfiguration.getDefaultConfiguration())
> >
> > Michael
>

--089e013c63e8bf29f704e230e2f8--