accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Drob <md...@mdrob.com>
Subject Re: Thrift generated files
Date Tue, 23 Jul 2013 03:18:19 GMT
Technically, you can. However, this is considered very bad practice, as the
next person to touch these is likely going to overwrite your changes and
then we'll have a mess of conflicts to deal with.


On Mon, Jul 22, 2013 at 11:14 PM, Supun Kamburugamuva <supun06@gmail.com>wrote:

> Just out of curiosity, without copying the generated files can't we extend
> from them and implement the required functionalities?
>
>
> On Mon, Jul 22, 2013 at 5:02 PM, Corey Nolet <cjnolet@gmail.com> wrote:
>
> > bq. do we have to copy the generated file in to source code and commit?
> >
> > I believe the script that generates the thrift files also diffs them
> > against the working tree and copies any changes where they go. At that
> > point, you should just be able to stage them for a commit.
> >
> >
> >
> > On Mon, Jul 22, 2013 at 7:38 PM, Josh Elser <josh.elser@gmail.com>
> wrote:
> >
> > > AFAIK, that's correct. Change the thrift definition and commit the new
> > > generated file.
> > >
> > >
> > > On 07/22/2013 07:27 PM, Supun Kamburugamuva wrote:
> > >
> > >> Hi all,
> > >>
> > >> I have a question about the thrift file generation. I can see you are
> > >> generating the java classes from the thrift files. If we change a
> thrift
> > >> file do we have to copy the generated file in to source code and
> commit?
> > >> I'm bit confused about the work-flow.
> > >>
> > >> Thanks,
> > >> Supun..
> > >>
> > >>
> >
>
>
>
> --
> Supun Kamburugamuva
> Member, Apache Software Foundation; http://www.apache.org
> E-mail: supun06@gmail.com;  Mobile: +1 812 369 6762
> Blog: http://supunk.blogspot.com
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message