accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Medinets <david.medin...@gmail.com>
Subject Re: One of Checkstyle's rules is 'no spaces at end of line', anyone upset if I update the code (1.6) to follow it?
Date Wed, 06 Mar 2013 20:20:10 GMT
+1 to change the formatter.

On Wed, Mar 6, 2013 at 3:18 PM, Billie Rinaldi <billie.rinaldi@gmail.com> wrote:
> I personally would prefer if we changed our formatter to have no spaces on
> blank lines.  git calls these "whitespace errors" when you're applying a
> patch.
>
> Billie
>
>
> On Wed, Mar 6, 2013 at 11:57 AM, Christopher <ctubbsii@apache.org> wrote:
>
>> Wouldn't that rule conflict with our formatter? I'm pretty sure our
>> formatter allows "blank" lines to be indented with spaces.
>>
>> --
>> Christopher L Tubbs II
>> http://gravatar.com/ctubbsii
>>
>>
>> On Wed, Mar 6, 2013 at 10:23 AM, David Medinets
>> <david.medinets@gmail.com> wrote:
>> > I have a free day due to snowfall and while this is a fairly silly
>> > rule, writing a short script to rule all the java files through sed
>> > should be fairly painless. As part of this change, I will commit a
>> > one-rule checkstyle.xml file which just runs this 'no spaces at end of
>> > line' rule. Over time, more rules can be added to that align with the
>> > Accumulo community's style guidelines.
>> >
>> > Any objection?
>>

Mime
View raw message