accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Vines <vi...@apache.org>
Subject Re: One of Checkstyle's rules is 'no spaces at end of line', anyone upset if I update the code (1.6) to follow it?
Date Thu, 07 Mar 2013 15:49:05 GMT
I've been getting unnecessary merge conflicts because of this change. At
the very least, I would like to see it reverted until we release 1.5


On Thu, Mar 7, 2013 at 10:44 AM, Keith Turner <keith@deenlo.com> wrote:

> On Wed, Mar 6, 2013 at 10:23 AM, David Medinets
> <david.medinets@gmail.com> wrote:
> > I have a free day due to snowfall and while this is a fairly silly
> > rule, writing a short script to rule all the java files through sed
> > should be fairly painless. As part of this change, I will commit a
> > one-rule checkstyle.xml file which just runs this 'no spaces at end of
> > line' rule. Over time, more rules can be added to that align with the
> > Accumulo community's style guidelines.
> >
> > Any objection?
>
> Whats the benefit of doing this?  How will it impact merges from 1.5
> to 1.6?  Should this be done for thrift generated code?
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message