accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Medinets <david.medin...@gmail.com>
Subject TableLoadBalancer.getTableOperations get instance from HdfsZooInstance ... can it use configuration.getInstance() instead .. to promote unit testing?
Date Fri, 04 Jan 2013 02:52:52 GMT
In trunk, the abstract TabletBalancer class has a configuration class variable:

  protected ServerConfiguration configuration;

The TableLoadBalancer class has a getTableOperations method that get
an instance value from HdfsZooInstance:

  protected TableOperations getTableOperations() {
    if (tops == null)
      try {
        tops = HdfsZooInstance.getInstance().getConnector(SecurityConstants.getSystemCredentials()).tableOperations();
      } catch (AccumuloException e) {
        log.error("Unable to access table operations from within table
balancer", e);
      } catch (AccumuloSecurityException e) {
        log.error("Unable to access table operations from within table
balancer", e);
      }
    return tops;
  }

Is there any reason why the TableLoadBalancer can't use its
configuration variable to find the accumulo instance?

Mime
View raw message