Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Received-SPF: pass (nike.apache.org: domain of david.medinets@gmail.com
 designates 209.85.220.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CADczPYRuGuz1g8uhpvrT3DTRFewr3-KVD5ZwfmNqBWJvs9LcTA@mail.gmail.com>
References: 
 <CAOiJXP5cJ4-y-NZaAPLtUAG7_812P39eLmuXW8GRnUjUfE+NUg@mail.gmail.com>
	<CADczPYRuGuz1g8uhpvrT3DTRFewr3-KVD5ZwfmNqBWJvs9LcTA@mail.gmail.com>
Date: Tue, 13 Nov 2012 13:50:36 -0500
Message-ID: 
 <CAOiJXP7OLtJFjB07BNa4cLOGODVYKGafHGMr5+Kzfm_M-e2Y5w@mail.gmail.com>
Subject: Re: Bug In Text Class - getLength() and getBytes().length are
 different.
From: David Medinets <david.medinets@gmail.com>
To: dev@accumulo.apache.org
Content-Type: text/plain; charset=ISO-8859-1

That makes sense. I have resolved my issue by passing the
Text.getLength() value along with Text.getBytes(). This works fine.
Thanks.

On Tue, Nov 13, 2012 at 1:23 PM, John Vines <vines@apache.org> wrote:
> This is not a bug. A Text object is a reusable object which prevents
> repeated creation of byte arrays, so it will use the same byte array,
> resizing it if necessary, and writing over the previous values. Doing any
> operation based on Text.getBytes().length has a strong potential to provide
> inaccurate results. Text.getLength() is the appropriate way to get the
> length of the underlying byte array that you care about.
>
> John
>
>
> On Tue, Nov 13, 2012 at 1:00 PM, David Medinets <david.medinets@gmail.com>wrote:
>
>> The following code (the TextTest class) displays:
>>
>> cq: [5000000000000000]
>> cq: [16]
>> cq: [16]
>> cq: [5000000000000000]
>> cq: [16]
>> cq: [17]
>>
>> You'll notice that the last two numbers are different, but they should
>> both be 16. This bug affects Accumulo because of the following code in
>> Mutation:
>>
>>   private void put(byte b[]) {
>>     buffer.writeVLong(b.length);
>>     buffer.add(b, 0, b.length);
>>   }
>>
>>   private void put(Text t) {
>>     buffer.writeVLong(t.getLength());
>>     buffer.add(t.getBytes(), 0, t.getLength());
>>   }
>>
>> I should be able to call either of the following to get the same
>> result but I can't.
>>
>>   put("5000000000000000".getBytes());
>>   put(new Text("5000000000000000"));
>>
>> Has anyone else run into this issue? Any workarounds or fixes?
>>
>> ----
>>
>> package com.codebits.accumulo;
>>
>> import org.apache.hadoop.io.Text;
>>
>> public class TextTest {
>>
>>   public static void main(String[] args) {
>>     String s = "5000000000000000";
>>     System.out.println("cq: [" + s + "]");
>>     System.out.println("cq: [" + s.length() + "]");
>>     System.out.println("cq: [" + s.getBytes().length + "]");
>>
>>     Text cq = new Text(s);
>>     System.out.println("cq: [" + cq + "]");
>>     System.out.println("cq: [" + cq.getLength() + "]");
>>     System.out.println("cq: [" + cq.getBytes().length + "]");
>>   }
>>
>> }
>>