accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request: Accumulo proxy source 11/13/12
Date Wed, 14 Nov 2012 19:28:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8039/#review13433
-----------------------------------------------------------



/trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
<https://reviews.apache.org/r/8039/#comment28788>

    Could  do a get here instead of contains key and put if null. Remember the result of the
get and user later.  Also remember the mutation when doing put.  This way just one lookup
in hashmap is done.   



/trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
<https://reviews.apache.org/r/8039/#comment28789>

    Might be worthwhile to have a map of ColumnVis and resuse them.  Can be expensive to construct
ColumnVis because it verifies expression.   Lookup in a hash map is cheaper.   Colvis Hashmap
could be local to function.



/trunk/proxy/src/main/thrift/proxy.thrift
<https://reviews.apache.org/r/8039/#comment28787>

    Creating ranges can be tricky.  It would be nice to provide thrift helper methods for
creating ranges.  For example could have a  methods like the following.
    
      PRange rowRange(binary startRow, binary endRow)
      PRange prefixRange(binary row);
    
    You can look at the helper functions in Range.  There are a lot of them.  At least want
to provide ones for rows.
    
    Could possibly provide the followingKey and followingPrefix functions that most helper
functions in Range build on.
    
    Also, why not have inclusive/exclusive booleans for range?


- kturner


On Nov. 14, 2012, 6:51 p.m., Chris McCubbin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8039/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 6:51 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Description
> -------
> 
> Patch submitted by Chris McCubbin to add thrift proxy to Accumulo, second version
> 
> 
> Diffs
> -----
> 
>   /trunk/pom.xml 1409290 
>   /trunk/proxy/README PRE-CREATION 
>   /trunk/proxy/accumulo-proxy.iml PRE-CREATION 
>   /trunk/proxy/examples/python/README PRE-CREATION 
>   /trunk/proxy/examples/python/TestClient.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/AccumuloProxy-remote PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/AccumuloProxy.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/__init__.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/constants.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/ttypes.py PRE-CREATION 
>   /trunk/proxy/examples/ruby/README PRE-CREATION 
>   /trunk/proxy/examples/ruby/accumulo_proxy.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/proxy_constants.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/proxy_types.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/test_client.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/thrift.rb PRE-CREATION 
>   /trunk/proxy/pom.xml PRE-CREATION 
>   /trunk/proxy/proxy.properties PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyHarness.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/TestProxyClient.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/Util.java PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloException.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloProxy.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloSecurityException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/IOException.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/KeyValueAndPeek.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/NoMoreEntriesException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PIteratorSetting.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PKey.java PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PKeyValue.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PRange.java PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PScanResult.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PSystemPermission.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PTablePermission.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableExistsException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableNotFoundException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/UserPass.java PRE-CREATION

>   /trunk/proxy/src/main/thrift/proxy.thrift PRE-CREATION 
>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyInstanceOperations.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyReadWrite.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxySecurityOperations.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyTableOperations.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/8039/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris McCubbin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message