accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris McCubbin" <ch...@sqrrl.com>
Subject Re: Review Request: Patch submitted by Chris McCubbin to add thrift proxy to Accumulo
Date Wed, 07 Nov 2012 21:55:48 GMT


> On Nov. 7, 2012, 9:41 p.m., kturner wrote:
> > /trunk/proxy/src/main/thrift/proxy.thrift, line 140
> > <https://reviews.apache.org/r/7936/diff/1/?file=186436#file186436line140>
> >
> >     Having a createBatchWriter(), flushBatchWriter(), closeBatchWriter() methods
will allow for a high performance write pipeline.  The single method makes the process synchronous,
the user has to wait for writes to complete before sending more.  With multiple methods, the
user could be sending a batch to the batch writer while the batch writer is sending the previous
batch.
> >     
> >     Could possibly offer both.  The single method that does everything in one shot
and multiple methods that allow a write pipeline.
> >     
> >

Good idea, I can take a stab at this.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7936/#review13224
-----------------------------------------------------------


On Nov. 7, 2012, 8:33 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7936/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 8:33 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Description
> -------
> 
> Patch submitted by Chris McCubbin to add thrift proxy to Accumulo
> 
> 
> This addresses bug ACCUMULO-482.
>     https://issues.apache.org/jira/browse/ACCUMULO-482
> 
> 
> Diffs
> -----
> 
>   /trunk/pom.xml 1406772 
>   /trunk/proxy/README PRE-CREATION 
>   /trunk/proxy/examples/python/README PRE-CREATION 
>   /trunk/proxy/examples/python/TestClient.py PRE-CREATION 
>   /trunk/proxy/examples/python/data/__init__.py PRE-CREATION 
>   /trunk/proxy/examples/python/data/constants.py PRE-CREATION 
>   /trunk/proxy/examples/python/data/ttypes.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/AccumuloProxy-remote PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/AccumuloProxy.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/__init__.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/constants.py PRE-CREATION 
>   /trunk/proxy/examples/python/proxy/ttypes.py PRE-CREATION 
>   /trunk/proxy/examples/ruby/README PRE-CREATION 
>   /trunk/proxy/examples/ruby/accumulo_proxy.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/data_constants.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/data_types.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/proxy_constants.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/proxy_types.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/test_client.rb PRE-CREATION 
>   /trunk/proxy/examples/ruby/thrift.rb PRE-CREATION 
>   /trunk/proxy/pom.xml PRE-CREATION 
>   /trunk/proxy/proxy.properties PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyHarness.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/TestProxyClient.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/Util.java PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloException.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloProxy.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloSecurityException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/IOException.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/KeyValueAndPeek.java PRE-CREATION

>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/NoMoreEntriesException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyIteratorSetting.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxySystemPermission.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyTablePermission.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableExistsException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableNotFoundException.java
PRE-CREATION 
>   /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/UserPass.java PRE-CREATION

>   /trunk/proxy/src/main/thrift/data.thrift PRE-CREATION 
>   /trunk/proxy/src/main/thrift/proxy.thrift PRE-CREATION 
>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyInstanceOperations.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyReadWrite.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxySecurityOperations.java PRE-CREATION

>   /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyTableOperations.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/7936/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message